Improve typechecking of webamp-modern

Author: captbaritone

packages/webamp-modern/package.json

@@ -22,7 +22,6 @@
   "devDependencies": {
     "@babel/core": "^7.17.10",
     "@babel/preset-env": "^7.17.10",
-    "@types/eslint": "^7.2.14",
     "@types/estree": "^0.0.50",
     "@types/jest": "^27.5.0",
     "@typescript-eslint/eslint-plugin": "^7.1.0",

packages/webamp-modern/src/skin/AudioPlayer.ts

@@ -43,7 +43,7 @@ export class AudioPlayer {
 
   constructor() {
     this._context = this._context = new (window.AudioContext ||
-      window.webkitAudioContext)();
+      (window as any).webkitAudioContext)();
 
     // Fix for iOS and Chrome (Canary) which require that the context be created
     // or resumed by a user interaction.

packages/webamp-modern/src/skin/TrueTypeFont.ts

@@ -40,7 +40,7 @@ export default class TrueTypeFont {
   }
 
   dispose() {
-    document.fonts.delete(this._fontFace);
+    (document.fonts as any).delete(this._fontFace);
   }
 
   getBase64() {
@@ -68,6 +68,6 @@ export default class TrueTypeFont {
 
     const font = new FontFace(fontFamily, `url(${fontUrl})`);
     this._fontFace = await font.load();
-    document.fonts.add(this._fontFace);
+    (document.fonts as any).add(this._fontFace);
   }
 }

packages/webamp-modern/src/skin/kjofolClasses/ButtonKjofol.ts

@@ -10,11 +10,11 @@ export default class ButtonKjofol extends Button {
 
   _renderX() {
     super._renderX();
-    this._div.style.setProperty("--left", px(-this._x ?? 0));
+    this._div.style.setProperty("--left", px(-this._x));
   }
 
   _renderY() {
     super._renderY();
-    this._div.style.setProperty("--top", px(-this._y ?? 0));
+    this._div.style.setProperty("--top", px(-this._y));
   }
 }

packages/webamp-modern/src/skin/kjofolClasses/ToggleButtonKjofol.ts

@@ -10,11 +10,11 @@ export default class ToggleButtonKjofol extends ToggleButton {
 
   _renderX() {
     super._renderX();
-    this._div.style.setProperty("--left", px(-this._x ?? 0));
+    this._div.style.setProperty("--left", px(-this._x));
   }
 
   _renderY() {
     super._renderY();
-    this._div.style.setProperty("--top", px(-this._y ?? 0));
+    this._div.style.setProperty("--top", px(-this._y));
   }
 }

packages/webamp-modern/src/skin/makiClasses/Status.ts

@@ -1,5 +1,6 @@
 import GuiObj from "./GuiObj";
 import { AUDIO_PAUSED, AUDIO_STOPPED, AUDIO_PLAYING } from "../AudioPlayer";
+import { UIRoot } from "../../UIRoot";
 
 // Maybe this?
 // http://wiki.winamp.com/wiki/XML_GUI_Objects#.3CWasabi:StandardFrame:Status.2F.3E

packages/webamp-modern/src/skin/makiClasses/SystemObject.ts

@@ -1316,6 +1316,7 @@ export default class SystemObject extends BaseObject {
    */
   getviewportheightfrompoint(x: number, y: number): number {
     // TODO
+    return unimplemented(0);
   }
 
   /**
@@ -1334,6 +1335,7 @@ export default class SystemObject extends BaseObject {
    */
   getmonitorheightfrompoint(x: number, y: number): number {
     // TODO
+    return unimplemented(0);
   }
 
   /**
@@ -1342,6 +1344,7 @@ export default class SystemObject extends BaseObject {
    */
   getmonitorheightfromguiobject(g: GuiObj): number {
     // TODO
+    return unimplemented(0);
   }
 
   /**
@@ -1359,6 +1362,7 @@ export default class SystemObject extends BaseObject {
    */
   getmonitorleftfromguiobject(g: GuiObj): number {
     // TODO
+    return unimplemented(0);
   }
 
   /**
@@ -1369,6 +1373,7 @@ export default class SystemObject extends BaseObject {
    */
   getmonitorleftfrompoint(x: number, y: number): number {
     // TODO
+    return unimplemented(0);
   }
 
   /**
@@ -1391,6 +1396,7 @@ export default class SystemObject extends BaseObject {
    */
   getmonitortopfromguiobject(g: GuiObj): number {
     // TODO
+    return unimplemented(0);
   }
 
   /**
@@ -1401,6 +1407,7 @@ export default class SystemObject extends BaseObject {
    */
   getmonitortopfrompoint(x: number, y: number): number {
     // TODO
+    return unimplemented(0);
   }
 
   getviewportleft(): number {
@@ -1425,6 +1432,7 @@ export default class SystemObject extends BaseObject {
    */
   getviewportleftfrompoint(x: number, y: number): number {
     // TODO
+    return unimplemented(0);
   }
 
   /**
@@ -1443,6 +1451,7 @@ export default class SystemObject extends BaseObject {
    */
   getviewporttopfrompoint(x: number, y: number): number {
     // TODO
+    return unimplemented(0);
   }
 
   /**

packages/webamp-modern/src/skin/makiClasses/WasabiTitle.ts

@@ -29,14 +29,14 @@ export default class WasabiTitleBar extends Group {
   _renderX() {
     this._div.style.left =
       this._relatx == "1"
-        ? relative(this._padtitleleft + this._x ?? 0)
-        : px(this._padtitleleft + this._x ?? 0);
+        ? relative(this._padtitleleft + this._x)
+        : px(this._padtitleleft + this._x);
   }
 
   _renderWidth() {
     this._div.style.width =
       this._relatw == "1"
-        ? relative(-this._padtitleleft + -this._padtitleright + this._w ?? 0)
+        ? relative(-this._padtitleleft + -this._padtitleright + this._w)
         : px(-this._padtitleright + this.getwidth());
   }
 

packages/webamp-modern/tsconfig.json

@@ -3,6 +3,17 @@
     "esModuleInterop": true,
     "allowJs": true,
     "resolveJsonModule": true,
-    "target": "es5"
-  }
+    "target": "es2018",
+    "lib": ["es2018", "dom"],
+    "downlevelIteration": true,
+    "skipLibCheck": true,
+    "moduleResolution": "node",
+    "strict": false,
+    "noEmit": true
+  },
+  "exclude": [
+    "node_modules",
+    "**/*.test.ts",
+    "tools/eslint-rules/proper-maki-types.ts"
+  ]
 }