fix: Remove modal from list after animation finishes

Akshat55 · Akshat55 · commit 00871f1c8725 · 2023-04-29T00:22:18.000-04:00
Signed-off-by: Akshat Patel &lt;akshat@live.ca&gt;
diff --git a/src/modal/base-modal.service.ts b/src/modal/base-modal.service.ts
@@ -85,8 +85,8 @@ export class BaseModalService {
 		// Let animation finish before component is removed
 		setTimeout(() => {
 			this.placeholderService.destroyComponent(BaseModalService.modalList[index]);
+			BaseModalService.modalList.splice(index, 1);
 		}, 240);
-		BaseModalService.modalList.splice(index, 1);
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -85,8 +85,8 @@ export class BaseModalService {`
`85`	`85`	`// Let animation finish before component is removed`
`86`	`86`	`setTimeout(() => {`
`87`	`87`	`this.placeholderService.destroyComponent(BaseModalService.modalList[index]);`
	`88`	`+ BaseModalService.modalList.splice(index, 1);`
`88`	`89`	`}, 240);`
`89`		`- BaseModalService.modalList.splice(index, 1);`
`90`	`90`	`}`
`91`	`91`	`}`
`92`	`92`