Skip to content

Commit 036fc0e

Browse files
authored
Merge pull request #521 from cal-smith/master
fix(pagination): fix a11y issues with selects and labels
2 parents e07982f + b714fce commit 036fc0e

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

src/pagination/pagination.component.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,16 +58,10 @@ import { ExperimentalService } from "./../experimental.module";
5858
[ngClass]="{
5959
'bx--select__item-count': isExperimental
6060
}">
61-
<label
62-
[for]="itemsPerPageSelectId"
63-
class="bx--label bx--visually-hidden">
64-
{{itemsPerPageText | async}}
65-
</label>
6661
<select
6762
[id]="itemsPerPageSelectId"
6863
[(ngModel)]="itemsPerPage"
69-
class="bx--select-input"
70-
aria-describedby="false">
64+
class="bx--select-input">
7165
<option class="bx--select-option" value="10">10</option>
7266
<option class="bx--select-option" value="20">20</option>
7367
<option class="bx--select-option" value="30">30</option>
@@ -104,7 +98,7 @@ import { ExperimentalService } from "./../experimental.module";
10498
'bx--select__page-number' : isExperimental
10599
}">
106100
<label [for]="currentPageSelectId" class="bx--label bx--visually-hidden">{{itemsPerPageText | async}}</label>
107-
<select [id]="currentPageSelectId" class="bx--select-input" aria-describedby="false" [(ngModel)]="currentPage">
101+
<select [id]="currentPageSelectId" class="bx--select-input" [(ngModel)]="currentPage">
108102
<option *ngFor="let i of range(lastPage + 1, 1)" class="bx--select-option" [value]="i">{{i}}</option>
109103
</select>
110104
<ibm-icon-chevron-down16

0 commit comments

Comments
 (0)