Skip to content

Commit 05e7078

Browse files
Akshat55zvonimirfrasdependabot[bot]kush-savaniflisijn
authored
Merging 'master' branch into 'next' (#3043)
Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Akshat Patel <[email protected]> Signed-off-by: Hubert Flisijn <[email protected]> Co-authored-by: Zvonimir Fras <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kaushal Savani <[email protected]> Co-authored-by: Hubert Flisijn <[email protected]> Co-authored-by: Klaas Cuvelier <[email protected]> Co-authored-by: Licen-it <[email protected]> Co-authored-by: Geoffrey Beertens <[email protected]> Co-authored-by: ArunKumar Nadikattu <[email protected]> Co-authored-by: Francine Lucca <[email protected]> Co-authored-by: Francine Lucca <[email protected]> Co-authored-by: Aaditya Menon <[email protected]> Co-authored-by: Yusuf Warda <[email protected]> Co-authored-by: Zvonimir Fras <[email protected]> Co-authored-by: Koen Van Durme <[email protected]> Co-authored-by: Abiram <[email protected]> Co-authored-by: Claudio Bertoli <[email protected]> Co-authored-by: João Vitor M. Gimenes <[email protected]> Co-authored-by: Eduard Marcinco <[email protected]> Co-authored-by: Daniel Sogl <[email protected]> Co-authored-by: grishma-shah7 <[email protected]> Co-authored-by: yegor dargin <[email protected]> Co-authored-by: Jeff Chew <[email protected]> Co-authored-by: Ignacio Becerra <[email protected]> Co-authored-by: brampeirs <[email protected]>
1 parent 212933e commit 05e7078

File tree

253 files changed

+46992
-13312
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

253 files changed

+46992
-13312
lines changed

.editorconfig

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,14 @@ indent_size = 4
1010
trim_trailing_whitespace = true
1111
insert_final_newline = true
1212

13+
[*.json]
14+
charset = utf-8
15+
end_of_file = lf
16+
indent_style = space
17+
indent_size = 2
18+
trim_trailing_whitespace = true
19+
insert_final_newline = true
20+
1321
[*.yml]
1422
charset = utf-8
1523
indent_style = space

.github/workflows/check-build.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@ jobs:
1111

1212
runs-on: ubuntu-latest
1313

14+
# We use Node v18 for building since CCA@v5 is using Angular 14.
1415
strategy:
1516
matrix:
16-
node-version: [16.x]
17+
node-version: [18.x]
1718

1819
steps:
1920
- uses: actions/checkout@v3
@@ -39,10 +40,11 @@ jobs:
3940

4041
runs-on: ubuntu-latest
4142

43+
# We use Node v20 for building since it is current lts. Node v16 is no longer supported in Angular 17.
4244
strategy:
4345
matrix:
44-
angular-version: [14, 15, 16]
45-
node-version: [16.x]
46+
angular-version: [14, 15, 16, 17, 18]
47+
node-version: [20.x]
4648

4749
steps:
4850
- uses: actions/checkout@v3

.github/workflows/publish.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,22 +8,30 @@ on:
88
# Allows us to run this workflow manually from the Actions tab
99
workflow_dispatch:
1010

11+
permissions:
12+
contents: read # for checkout
13+
1114
jobs:
1215
# Single deploy job since we're just deploying
1316
publish:
1417
environment:
1518
name: Deploy
1619
runs-on: ubuntu-latest
20+
permissions:
21+
contents: write # to be able to publish a GitHub release
22+
issues: write # to be able to comment on released issues
23+
pull-requests: write # to be able to comment on pull requests
24+
id-token: write # to enable use of ODIC for npm provenance
1725
steps:
1826
# Checkout to branch
1927
- name: Checkout
2028
uses: actions/checkout@v3
2129

22-
# Set up node to use v16
30+
# Set up node to use v18
2331
- name: Setup Node
2432
uses: actions/setup-node@v3
2533
with:
26-
node-version: "16"
34+
node-version: "18"
2735
cache: "npm"
2836
cache-dependency-path: "package-lock.json"
2937

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/.angular/cache
1+
.angular/cache
22
.DS_Store
33
*.log*
44
*.swp

.storybook/main.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ module.exports = {
1010
backgrounds: false
1111
}
1212
},
13-
"@storybook/addon-a11y"
13+
"@storybook/addon-a11y",
14+
"@storybook/addon-storysource"
1415
],
1516
framework: {
1617
name: "@storybook/angular",

.storybook/manager-head.html

Lines changed: 54 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,63 @@
1010
<meta name="twitter:image" content="https://angular.carbondesignsystem.com/carbon.jpg">
1111
<meta name="twitter:card" content="summary_large_image">
1212

13+
<footer>
14+
<dds-footer-container key="footer" disable-locale-button="true" size="micro" />
15+
</footer>
16+
17+
<script
18+
key="8"
19+
type="module"
20+
src="https://1.www.s81c.com/common/carbon-for-ibm-dotcom/tag/v1/latest/footer.min.js">
21+
</script>
22+
1323
<!-- Storybook override -->
1424
<script>
1525
document.title = "Carbon Components Angular";
1626
</script>
1727

18-
<!-- Google Analytics v4 setup -->
19-
<script async src="https://www.googletagmanager.com/gtag/js?id=G-G070S732G6"></script>
20-
<script>
21-
window.dataLayer = window.dataLayer || [];
22-
function gtag() { dataLayer.push(arguments); }
23-
gtag('js', new Date());
24-
25-
gtag('config', 'G-G070S732G6', {
26-
send_page_view: false
27-
});
28+
<!-- Tealium/GA Set up -->
29+
<script type="text/javascript">
30+
window._ibmAnalytics = {
31+
settings: {
32+
name: 'CarbonAngularStorybook',
33+
isSpa: true,
34+
tealiumProfileName: 'ibm-web-app',
35+
},
36+
onLoad: [['ibmStats.pageview', []]],
37+
};
38+
digitalData = {
39+
page: {
40+
pageInfo: {
41+
ibm: {
42+
siteId: 'IBM_' + _ibmAnalytics.settings.name,
43+
},
44+
},
45+
category: {
46+
primaryCategory: 'PC100',
47+
},
48+
},
49+
};
50+
</script>
51+
<script
52+
src="//1.www.s81c.com/common/stats/ibm-common.js"
53+
type="text/javascript"
54+
async="async">
2855
</script>
56+
57+
<style>
58+
footer {
59+
position: absolute;
60+
bottom: 0;
61+
width: 100%;
62+
z-index: 9999;
63+
}
64+
65+
#root > div {
66+
/*
67+
* Subtracting the height of the footer to prevent
68+
* overlaying the footer ontop of content
69+
*/
70+
height: calc(100vh - 48px);
71+
}
72+
</style>

.storybook/preview.scss

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,14 @@ html {
66
@include styles.theme(styles.$white);
77
}
88

9+
.innerZoomElementWrapper {
10+
min-width: 55rem;
11+
}
12+
13+
.docblock-argstable {
14+
margin-bottom: 10rem;
15+
}
16+
917
/*
1018
* Story batch styling, we are wrapping the storybook decorator function to ensure
1119
* styles do not leak to other components

README.md

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ That's it! Now we can run `npm start` and start building out our application!
5555
- IBMers should use our #carbon-ng Slack channel
5656

5757
Angular version support matrix:
58-
| Angular | v3 | v4 | v5 (future release) |
58+
| Angular | v3 | v4 | v5 |
5959
| ------- | -- | -- | ------------------- |
6060
| 6 ||||
6161
| 7 ||||
@@ -68,6 +68,8 @@ Angular version support matrix:
6868
| 14 ||||
6969
| 15 ||||
7070
| 16 ||||
71+
| 17 ||||
72+
| 18 ||||
7173

7274
Carbon Components Angular version support matrix:
7375
| Carbon Components Angular version | Community support | Active support |
@@ -99,7 +101,7 @@ How to read this table:
99101
- **if you are contributing a fix**:
100102
- add your fix, update the documentation as needed
101103
- consider adding or modifying a test case to cover the fix
102-
- follow the [Angular style guide](https://angular.io/styleguide)
104+
- follow the [Angular style guide](https://angular.dev/style-guide)
103105
- be sure to run `npm test` and `npm run lint` to make sure the tests and linter pass
104106
- submit a PR
105107

@@ -163,3 +165,11 @@ To keep our build dependencies local we use npm scripts to run our webpack, gulp
163165

164166
## Code of Conduct
165167
Read our code of conduct [here](./.github/CODE_OF_CONDUCT.md)
168+
169+
## <picture><source height="20" width="20" media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-dark.svg"><source height="20" width="20" media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-light.svg"><img height="20" width="20" alt="IBM Telemetry" src="https://raw.githubusercontent.com/ibm-telemetry/telemetry-js/main/docs/images/ibm-telemetry-light.svg"></picture> IBM Telemetry
170+
171+
This package uses IBM Telemetry to collect de-identified and anonymized metrics data. By installing
172+
this package as a dependency you are agreeing to telemetry collection. To opt out, see
173+
[Opting out of IBM Telemetry data collection](https://github.com/ibm-telemetry/telemetry-js/tree/main#opting-out-of-ibm-telemetry-data-collection).
174+
For more information on the data being collected, please see the
175+
[IBM Telemetry documentation](https://github.com/ibm-telemetry/telemetry-js/tree/main#ibm-telemetry-collection-basics).

angular.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,8 @@
7171
"-t"
7272
],
7373
"configDir": ".storybook",
74-
"outputDir": "dist/docs/storybook"
74+
"outputDir": "dist/docs/storybook",
75+
"enableProdMode": false
7576
}
7677
}
7778
}

0 commit comments

Comments
 (0)