Skip to content

Commit 0f8e94a

Browse files
committed
fix: use default overflow menu & pass in description/autoAlign
Signed-off-by: Akshat Patel <[email protected]>
1 parent 47ce97e commit 0f8e94a

File tree

2 files changed

+29
-30
lines changed

2 files changed

+29
-30
lines changed

src/breadcrumb/breadcrumb.component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,6 @@ describe("Breadcrumb", () => {
120120
const breadcrumbItemElements = testFixture.debugElement.queryAll(By.directive(BreadcrumbItemComponent));
121121
expect(breadcrumbItemElements).not.toBeNull();
122122
expect(breadcrumbItemElements.length).toBe(4); // 4 because one is created for the overflow menu
123-
expect(breadcrumbItemElements[1].children[0].name).toEqual("cds-icon-button");
123+
expect(breadcrumbItemElements[1].children[0].name).toEqual("cds-overflow-menu");
124124
});
125125
});

src/breadcrumb/breadcrumb.component.ts

Lines changed: 28 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -71,34 +71,29 @@ const MINIMUM_OVERFLOW_THRESHOLD = 4;
7171
</ng-template>
7272
</cds-breadcrumb-item>
7373
<cds-breadcrumb-item>
74-
<cds-icon-button
75-
[buttonNgClass]="{ 'cds--overflow-menu': true }"
76-
type="button"
77-
kind="ghost"
78-
size="md"
79-
[description]="overflowMenuDescription">
80-
<ng-template #overflowMenuTrigger>
81-
<svg class="cds--overflow-menu__icon" cdsIcon="overflow-menu--horizontal" size="16"></svg>
82-
</ng-template>
83-
<cds-overflow-menu
84-
[customTrigger]="overflowMenuTrigger"
85-
triggerClass="cds--btn--icon-only">
86-
<li class="cds--overflow-menu-options__option"
87-
*ngFor="let item of overflowItems">
88-
<a class="cds--overflow-menu-options__btn"
89-
href="{{item?.href}}"
90-
(click)="navigate($event, item)"
91-
style="text-decoration: none;">
92-
<ng-container *ngIf="!item?.template">{{item?.content}}</ng-container>
93-
<ng-template
94-
*ngIf="item?.template"
95-
[ngTemplateOutlet]="item?.template"
96-
[ngTemplateOutletContext]="{ $implicit: item }">
97-
</ng-template>
98-
</a>
99-
</li>
100-
</cds-overflow-menu>
101-
</cds-icon-button>
74+
<ng-template #overflowMenuTrigger>
75+
<svg class="cds--overflow-menu__icon" cdsIcon="overflow-menu--horizontal" size="16"></svg>
76+
</ng-template>
77+
<cds-overflow-menu
78+
[customTrigger]="overflowMenuTrigger"
79+
triggerClass="cds--btn--icon-only"
80+
[description]="description"
81+
[autoAlign]="autoAlign">
82+
<li class="cds--overflow-menu-options__option"
83+
*ngFor="let item of overflowItems">
84+
<a class="cds--overflow-menu-options__btn"
85+
href="{{item?.href}}"
86+
(click)="navigate($event, item)"
87+
style="text-decoration: none;">
88+
<ng-container *ngIf="!item?.template">{{item?.content}}</ng-container>
89+
<ng-template
90+
*ngIf="item?.template"
91+
[ngTemplateOutlet]="item?.template"
92+
[ngTemplateOutletContext]="{ $implicit: item }">
93+
</ng-template>
94+
</a>
95+
</li>
96+
</cds-overflow-menu>
10297
</cds-breadcrumb-item>
10398
<cds-breadcrumb-item
10499
[href]="secondLast?.href"
@@ -162,7 +157,11 @@ export class Breadcrumb implements AfterContentInit {
162157
return this._threshold;
163158
}
164159

165-
@Input() overflowMenuDescription: string = this.i18n.get().BREADCRUMB.OVERFLOW_MENU_DESCRIPTION;
160+
/**
161+
* **Experimental**: Auto align menu tooltip position
162+
*/
163+
@Input() autoAlign = false;
164+
@Input() description: string = this.i18n.get().BREADCRUMB.OVERFLOW_MENU_DESCRIPTION;
166165

167166
/**
168167
* Emits the navigation status promise when the link is activated

0 commit comments

Comments
 (0)