Skip to content

Commit 1069643

Browse files
authored
feat: add placeholder for ibm number (#2511)
1 parent f624f79 commit 1069643

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

src/number-input/number.component.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ export class NumberChange {
6767
[required]="required"
6868
[attr.aria-label]="ariaLabel"
6969
[attr.data-invalid]="invalid ? invalid : null"
70+
[placeholder]="placeholder"
7071
(input)="onNumberInputChange($event)"/>
7172
<svg
7273
*ngIf="!skeleton && !warn && invalid"
@@ -155,6 +156,10 @@ export class NumberComponent implements ControlValueAccessor {
155156
* The unique id for the number component.
156157
*/
157158
@Input() id = `number-${NumberComponent.numberCount}`;
159+
/**
160+
* Sets the placeholder attribute on the `input` element.
161+
*/
162+
@Input() placeholder = "";
158163
/**
159164
* Number input field render size
160165
*/

src/number-input/number.stories.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ storiesOf("Components|Number", module).addDecorator(
3535
[warn]="warn"
3636
[warnText]="warnText"
3737
[size]="size"
38-
[disabled]="disabled">
38+
[disabled]="disabled"
39+
[placeholder]="placeholder">
3940
</ibm-number>
4041
`,
4142
props: {
@@ -51,7 +52,8 @@ storiesOf("Components|Number", module).addDecorator(
5152
step: number("step", 1),
5253
precision: number("precision"),
5354
invalid: boolean("Show form validation (invalid)", false),
54-
disabled: boolean("disabled", false)
55+
disabled: boolean("disabled", false),
56+
placeholder: text("Placeholder text", "Placeholder text")
5557
}
5658
}))
5759
.add("With ngModel", () => ({
@@ -68,6 +70,7 @@ storiesOf("Components|Number", module).addDecorator(
6870
[invalid]="invalid"
6971
[invalidText]="invalidText"
7072
[disabled]="disabled"
73+
[placeholder]="placeholder"
7174
[(ngModel)]="value">
7275
</ibm-number>
7376
{{ value }}
@@ -84,7 +87,8 @@ storiesOf("Components|Number", module).addDecorator(
8487
step: number("step", 1),
8588
precision: number("precision"),
8689
invalid: boolean("Show form validation", false),
87-
disabled: boolean("disabled", false)
90+
disabled: boolean("disabled", false),
91+
placeholder: text("Placeholder text", "Placeholder text")
8892
}
8993
}))
9094
.add("Skeleton", () => ({

0 commit comments

Comments
 (0)