fix: check if change has been made to input

Akshat55 · Akshat55 · commit 231492154a97 · 2023-06-27T21:15:39.000-04:00
Signed-off-by: Akshat Patel &lt;akshat@live.ca&gt;
diff --git a/src/icon/icon.directive.ts b/src/icon/icon.directive.ts
@@ -126,7 +126,7 @@ export class IconDirective implements AfterViewInit, OnChanges {
 	ngOnChanges({ cdsIcon }: SimpleChanges) {
 		// We want to ignore first change to let the icon register
 		// and add only after view has been initialized
-		if (!cdsIcon.isFirstChange()) {
+		if (cdsIcon && !cdsIcon.isFirstChange()) {
 			this.renderIcon(this.cdsIcon);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ export class IconDirective implements AfterViewInit, OnChanges {`
`126`	`126`	`ngOnChanges({ cdsIcon }: SimpleChanges) {`
`127`	`127`	`// We want to ignore first change to let the icon register`
`128`	`128`	`// and add only after view has been initialized`
`129`		`- if (!cdsIcon.isFirstChange()) {`
	`129`	`+ if (cdsIcon && !cdsIcon.isFirstChange()) {`
`130`	`130`	`this.renderIcon(this.cdsIcon);`
`131`	`131`	`}`
`132`	`132`	`}`