update modal service to catch deprecated props

Author: cal-smith

src/modal/alert-modal.interface.ts

@@ -1,3 +1,8 @@
+export enum AlertModalType {
+	default = "default",
+	danger = "danger"
+}
+
 export interface AlertModalData {
 	/**
 	 * Use of `modalType` is deprecated, use `type` instead
@@ -6,7 +11,7 @@ export interface AlertModalData {
 	/**
 	 * type of the modal
 	 */
-	type?: "default" | "danger";
+	type?: AlertModalType;
 	/**
 	 * Use of `modalLabel` is deprecated, use `label` instead
 	 */

src/modal/modal.service.ts

@@ -88,6 +88,15 @@ export class ModalService {
 	 * @memberof ModalService
 	 */
 	show(data: AlertModalData) {
+		for (let key of Object.keys(data)) {
+			if (["modalType", "modalLabel", "modalTitle", "modalContent"].includes(key)) {
+				try {
+					throw new Error(`${key} is deprecated, use ${key.replace("modal", "").toLowerCase()} instead`);
+				} catch (error) {
+					console.warn(error);
+				}
+			}
+		}
 		return this.create({
 			component: AlertModalComponent,
 			inputs: {

src/modal/modal.stories.ts

@@ -7,7 +7,7 @@ import { ModalModule } from "../";
 import { Component, Input, Inject } from "@angular/core";
 import { BrowserAnimationsModule } from "@angular/platform-browser/animations";
 import { Modal, ModalService } from "../";
-import { ModalButton } from "./alert-modal.interface";
+import { ModalButton, AlertModalType } from "./alert-modal.interface";
 
 @Modal()
 @Component({
@@ -61,7 +61,7 @@ class ModalStory {
 	`
 })
 class AlertModalStory {
-	@Input() modalType: any;
+	@Input() modalType: AlertModalType;
 	@Input() modalLabel: string;
 	@Input() modalTitle: string;
 	@Input() modalContent: string;
@@ -71,7 +71,7 @@ class AlertModalStory {
 
 	openModal() {
 		this.modalService.show({
-			type: this.modalType,
+			modalType: this.modalType,
 			label: this.modalLabel,
 			title: this.modalTitle,
 			content: this.modalContent,