Merge branch 'appendto' of github.com:cal-smith/carbon-components-angular into appendto

Author: cal-smith

src/dialog/dialog.directive.ts

@@ -67,9 +67,9 @@ export class DialogDirective implements OnInit, OnDestroy, OnChanges {
 	 * Value `true` sets Dialog be appened to the body (to break out of containers)
 	 */
 	@Input() set appendToBody(v: boolean) {
-		console.log("appendToBody has been deprecated. dialogs now append to the body by default.");
-		console.log("ensure you have an ibm-placeholder in your app.");
-		console.log("use appendInline if you need to position your dialogs within the normal page flow");
+		console.log("`appendToBody` has been deprecated. Dialogs now append to the body by default.");
+		console.log("Ensure you have an `ibm-placeholder` in your app.");
+		console.log("Use `appendInline` if you need to position your dialogs within the normal page flow.");
 		this.appendInline = !v;
 	}
 	get appendToBody() {

src/dialog/dialog.service.ts

@@ -106,7 +106,7 @@ export class DialogService {
 			if (dialogConfig.appendInline) {
 				// add our component to the view
 				this.dialogRef = viewContainer.createComponent(this.componentFactory, 0, this.injector);
-			} else if (this.placeholderService.hasPlaceholderRef()) {
+			} else if (!this.placeholderService.hasPlaceholderRef()) {
 				this.dialogRef = viewContainer.createComponent(this.componentFactory, 0, this.injector);
 				setTimeout(() => {
 					window.document.querySelector("body").appendChild(this.dialogRef.location.nativeElement);

src/dropdown/dropdown.component.ts

@@ -101,9 +101,9 @@ export class Dropdown implements OnInit, AfterContentInit, OnDestroy {
 	 * Set to `true` if the `Dropdown` is to be appended to the DOM body.
 	 */
 	@Input() set appendToBody (v) {
-		console.log("appendToBody has been deprecated. dropdowns now append to the body by default.");
-		console.log("ensure you have an ibm-placeholder in your app.");
-		console.log("use appendInline if you need to position your dropdowns within the normal page flow");
+		console.log("`appendToBody` has been deprecated. Dropdowns now append to the body by default.");
+		console.log("Ensure you have an `ibm-placeholder` in your app.");
+		console.log("Use `appendInline` if you need to position your dropdowns within the normal page flow.");
 		this.appendInline = !v;
 	}
 

src/modal/modal.component.ts

@@ -44,7 +44,7 @@ import { cycleTabs } from "./../common/tab.service";
  * 			<ibm-modal-header (closeSelect)="closeModal()">Header text</ibm-modal-header>
  * 			<section class="modal-body">
  * 			<h1>Sample modal works.</h1>
- * 			<button class="btn--icon-link" nPopover="Hello there" title="Popover title" placement="right">
+ * 			<button class="btn--icon-link" nPopover="Hello there" title="Popover title" placement="right" appendInline="true">
  * 				<ibm-icon icon="info" size="sm"></ibm-icon>
  * 			</button>
  * 			{{modalText}}