Merge branch 'master' into feat/search

Author: Evan SUAU

CODEOWNERS

@@ -1 +1 @@
-* @cal-smith @zvonimirfras @magedhennawy
+* @cal-smith @zvonimirfras @magedhennawy @youda97

README.md

@@ -31,28 +31,7 @@ Then we need to include carbon-components in `src/styles.scss`:
 
 > *Note:* For offline usage we'll need to set `$font-path: '~carbon-components/src/globals/fonts';` at the very top of our `src/styles.scss`. This will copy the fonts to our `dist` folder upon successful build. If you like the fonts to be a part of your `assets` folder and not pollute the `dist` folder then copy the fonts from `node_modules/carbon-components/src/globals/fonts` into our app's `src/assets/fonts` folder and add `$font-path: '/assets/fonts/';` at the very top of our `src/styles.scss`.
 
-Then set up our translations in `src/app/app.module.ts`:
-
-```ts
-import { BrowserModule } from '@angular/platform-browser';
-import { NgModule } from '@angular/core';
-
-import { AppComponent } from './app.component';
-
-@NgModule({
-  declarations: [
-    AppComponent
-  ],
-  imports: [
-	BrowserModule,
-  ],
-  providers: [],
-  bootstrap: [AppComponent]
-})
-export class AppModule { }
-```
-
-_Finally_ we can run `npm start` and start building out our application!
+That's it! Now we can run `npm start` and start building out our application!
 
 > *Note:* This isn't the only way to bootstrap a `carbon-components-angular` application, but the combination of `@angular/cli` and the `carbon-components` scss is our recommended setup.
 

src/dialog/overflow-menu/overflow-menu-pane.component.ts

@@ -19,7 +19,8 @@ import { I18n } from "./../../i18n/i18n.module";
 			#dialog
 			class="bx--overflow-menu-options bx--overflow-menu-options--open"
 			role="menu"
-			(focusout)="clickClose($event)"
+			(focusout)="menuClose($event)"
+			(click)="doClose()"
 			[attr.aria-label]="dialogConfig.menuLabel">
 			<ng-template
 				[ngTemplateOutlet]="dialogConfig.content"
@@ -110,14 +111,10 @@ export class OverflowMenuPane extends Dialog {
 		}
 	}
 
-	clickClose(event) {
-		// Opens menu when clicking on the menu button and stays open while navigating through the options
-		if (this.dialogConfig.parentRef.nativeElement.firstChild.contains(event.target) ||
-			this.listItems().some(button => button === event.relatedTarget) ||
-			event.type === "focusout" && event.relatedTarget === this.dialogConfig.parentRef.nativeElement) {
-			return;
+	menuClose(event) {
+		if (this.listItems().some(button => button === document.activeElement)) {
+			this.doClose();
 		}
-		this.doClose();
 	}
 
 	protected listItems() {

src/dialog/tooltip/tooltip.stories.ts

@@ -3,13 +3,13 @@ import { withNotes } from "@storybook/addon-notes";
 import { action } from "@storybook/addon-actions";
 import { withKnobs, boolean, object } from "@storybook/addon-knobs/angular";
 
-import { DialogModule } from "../../";
+import { DialogModule, PlaceholderModule } from "../../";
 
 storiesOf("Tooltip", module)
 	.addDecorator(
 		moduleMetadata({
 			imports: [
-				DialogModule
+				DialogModule, PlaceholderModule
 			]
 		})
 	)