Skip to content

Commit 4032d98

Browse files
authored
fix: use hidden label instead of aria label for table checkbox (#2956)
Signed-off-by: Akshat Patel <[email protected]>
1 parent f6fa05f commit 4032d98

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/table/cell/table-checkbox.component.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,11 @@ import { TableRowSize } from "../table.types";
1818
*ngIf="!skeleton"
1919
inline="true"
2020
[name]="name"
21-
[ariaLabel]="getLabel() | i18nReplace:getSelectionLabelValue(row) | async"
2221
[checked]="selected"
2322
[disabled]="disabled"
24-
(checkedChange)="selectedChange.emit()">
23+
(checkedChange)="selectedChange.emit()"
24+
[hideLabel]="true">
25+
{{getLabel() | i18nReplace:getSelectionLabelValue(row) | async}}
2526
</cds-checkbox>
2627
`
2728
})

src/table/head/table-head-checkbox.component.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ import { Observable } from "rxjs";
1919
[checked]="checked"
2020
[indeterminate]="indeterminate"
2121
(checkedChange)="change.emit()"
22-
[ariaLabel]="getAriaLabel() | async">
22+
[hideLabel]="true">
23+
{{getAriaLabel() | async}}
2324
</cds-checkbox>
2425
`,
2526
styles: [`

0 commit comments

Comments
 (0)