Skip to content

Commit 4232578

Browse files
authored
Merge pull request #2483 from stanislavgeorgiev/issue-2479
Issue 2479: Progress Indicator: Design is different from the Carbon Components
2 parents 553f5ce + 6ee0775 commit 4232578

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

src/icon/icon.module.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import CheckmarkFilled20 from "@carbon/icons/es/checkmark--filled/20";
2424
import CheckmarkOutline16 from "@carbon/icons/es/checkmark--outline/16";
2525
import ChevronDown16 from "@carbon/icons/es/chevron--down/16";
2626
import ChevronRight16 from "@carbon/icons/es/chevron--right/16";
27+
import CircleDash16 from "@carbon/icons/es/circle-dash/16";
2728
import Close16 from "@carbon/icons/es/close/16";
2829
import Close20 from "@carbon/icons/es/close/20";
2930
import Copy16 from "@carbon/icons/es/copy/16";
@@ -38,6 +39,7 @@ import ErrorFilled16 from "@carbon/icons/es/error--filled/16";
3839
import ErrorFilled20 from "@carbon/icons/es/error--filled/20";
3940
import Fade16 from "@carbon/icons/es/fade/16";
4041
import Fade20 from "@carbon/icons/es/fade/20";
42+
import Incomplete16 from "@carbon/icons/es/incomplete/16";
4143
import InformationFilled16 from "@carbon/icons/es/information--filled/16";
4244
import InformationFilled20 from "@carbon/icons/es/information--filled/20";
4345
import Menu16 from "@carbon/icons/es/menu/16";
@@ -100,6 +102,7 @@ export class IconModule {
100102
CheckmarkOutline16,
101103
ChevronDown16,
102104
ChevronRight16,
105+
CircleDash16,
103106
Close16,
104107
Close20,
105108
Copy16,
@@ -114,6 +117,7 @@ export class IconModule {
114117
ErrorFilled20,
115118
Fade16,
116119
Fade20,
120+
Incomplete16,
117121
InformationFilled16,
118122
InformationFilled20,
119123
Menu16,

src/progress-indicator/progress-indicator.component.ts

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,11 @@ import { Step } from "./progress-indicator-step.interface";
2929
*ngFor="let step of steps; let i = index"
3030
[ngClass]="{'bx--progress-step--disabled' : step.disabled}">
3131
<div class="bx--progress-step-button bx--progress-step-button--unclickable" role="button" tabindex="-1">
32-
<svg ibmIcon="checkmark--outline" size="16" *ngIf="step.state.includes('complete')"></svg>
33-
<svg *ngIf="step.state.includes('current')">
34-
<path d="M 7, 7 m -7, 0 a 7,7 0 1,0 14,0 a 7,7 0 1,0 -14,0" ></path>
35-
</svg>
36-
<svg *ngIf="step.state.includes('incomplete')">
37-
<path
38-
d="M8 1C4.1 1 1 4.1 1 8s3.1 7 7 7 7-3.1 7-7-3.1-7-7-7zm0 13c-3.3 0-6-2.7-6-6s2.7-6 6-6 6 2.7 6 6-2.7 6-6 6z">
39-
</path>
40-
</svg>
32+
<ng-container *ngIf="!step.state.includes('error')">
33+
<svg ibmIcon="checkmark--outline" size="16" *ngIf="step.state.includes('complete')"></svg>
34+
<svg ibmIcon="incomplete" size="16" *ngIf="step.state.includes('current')"></svg>
35+
<svg ibmIcon="circle-dash" size="16" *ngIf="step.state.includes('incomplete')"></svg>
36+
</ng-container>
4137
<svg ibmIcon="warning" size="16" *ngIf="step.state.includes('error')" class="bx--progress__warning"></svg>
4238
<p
4339
class="bx--progress-label"
@@ -64,7 +60,7 @@ export class ProgressIndicator implements OnChanges {
6460
static skeletonSteps(stepCount: number) {
6561
const steps = [];
6662
for (let i = 0; i < stepCount; i++) {
67-
steps.push({"state": ["incomplete"]});
63+
steps.push({ "state": ["incomplete"] });
6864
}
6965

7066
return steps;

0 commit comments

Comments
 (0)