Merge pull request #2212 from kush-savani/issue2185

fix: set default aria-label for breadcrumb nav

Author: zvonimirfras

src/breadcrumb/breadcrumb.component.spec.ts

@@ -2,6 +2,7 @@ import { Component } from "@angular/core";
 import { CUSTOM_ELEMENTS_SCHEMA } from "@angular/core";
 import { async, ComponentFixture, TestBed } from "@angular/core/testing";
 import { FormsModule } from "@angular/forms";
+import { I18nModule } from "../i18n/index";
 import { By } from "@angular/platform-browser";
 import { BrowserDynamicTestingModule, platformBrowserDynamicTesting } from "@angular/platform-browser-dynamic/testing";
 
@@ -61,7 +62,10 @@ describe("Breadcrumb", () => {
 		TestBed.initTestEnvironment(BrowserDynamicTestingModule, platformBrowserDynamicTesting());
 
 		TestBed.configureTestingModule({
-			imports: [FormsModule],
+			imports: [
+				FormsModule,
+				I18nModule
+			],
 			schemas: [CUSTOM_ELEMENTS_SCHEMA],
 			declarations: [
 				Breadcrumb,

src/breadcrumb/breadcrumb.component.ts

@@ -12,8 +12,8 @@ import {
 
 import { BreadcrumbItem } from "./breadcrumb-item.interface";
 import { BreadcrumbItemComponent } from "./breadcrumb-item.component";
-import { DomSanitizer } from "@angular/platform-browser";
 import { Router } from "@angular/router";
+import { I18n } from "carbon-components-angular/i18n";
 
 const MINIMUM_OVERFLOW_THRESHOLD = 4;
 
@@ -122,7 +122,7 @@ export class Breadcrumb implements AfterContentInit {
 
 	@Input() noTrailingSlash = false;
 
-	@Input() ariaLabel: string;
+	@Input() ariaLabel: string = this.i18n.get().BREADCRUMB.LABEL;
 
 	@Input()
 	set skeleton(value: any) {
@@ -181,7 +181,7 @@ export class Breadcrumb implements AfterContentInit {
 	protected _threshold: number;
 	protected _skeleton = false;
 
-	constructor(protected domSanitizer: DomSanitizer, @Optional() protected router: Router) { }
+	constructor(protected i18n: I18n, @Optional() protected router: Router) { }
 
 	ngAfterContentInit() {
 		this.updateChildren();

src/breadcrumb/breadcrumb.module.ts

@@ -2,6 +2,7 @@ import { NgModule } from "@angular/core";
 import { CommonModule } from "@angular/common";
 
 import { DialogModule } from "carbon-components-angular/dialog";
+import { I18nModule } from "carbon-components-angular/i18n";
 
 import { Breadcrumb } from "./breadcrumb.component";
 import { BreadcrumbItemComponent } from "./breadcrumb-item.component";
@@ -17,7 +18,8 @@ import { BreadcrumbItemComponent } from "./breadcrumb-item.component";
 	],
 	imports: [
 		CommonModule,
-		DialogModule
+		DialogModule,
+		I18nModule
 	]
 })
 export class BreadcrumbModule { }

src/i18n/en.ts

@@ -2,6 +2,9 @@ export default {
 	"BANNER": {
 		"CLOSE_BUTTON": "Close alert banner"
 	},
+	"BREADCRUMB": {
+		"LABEL": "Breadcrumb"
+	},
 	"CALENDAR": {
 		"MONTHS": {
 			"JANUARY": "January",