Skip to content

Commit 4b1d81a

Browse files
committed
Fix DAP issues
1 parent 8cb9238 commit 4b1d81a

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

src/dialog/overflow-menu/overflow-menu-option.component.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import {
2222
template: `
2323
<button
2424
class="bx--overflow-menu-options__btn"
25+
role="menuitem"
2526
[ngClass]="{
2627
'bx--overflow-menu-options__option--danger': type === 'danger',
2728
'bx--overflow-menu-options__option--disabled': disabled
@@ -34,7 +35,7 @@ import {
3435
})
3536
export class OverflowMenuOption {
3637
@HostBinding("class") optionClass = "bx--overflow-menu-options__option";
37-
@HostBinding("attr.role") role = "list-item";
38+
@HostBinding("attr.role") role = "presentation";
3839

3940
/**
4041
* toggles between `normal` and `danger` states

src/dialog/overflow-menu/overflow-menu-pane.component.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ import { isFocusInLastItem, isFocusInFirstItem } from "./../../common/tab.servic
1212
selector: "ibm-overflow-menu-pane",
1313
template: `
1414
<ul
15+
role="menu"
16+
aria-label="Overflow"
1517
#dialog
1618
class="bx--overflow-menu-options bx--overflow-menu-options--open">
1719
<ng-template

src/dialog/overflow-menu/overflow-menu.component.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,13 @@ import { Component } from "@angular/core";
1616
selector: "ibm-overflow-menu",
1717
template: `
1818
<div
19+
#menu
1920
[ibmOverflowMenu]="options"
2021
[appendToBody]="true"
21-
placement="bottom"
22+
aria-label="Overflow"
2223
class="bx--overflow-menu"
24+
role="button"
25+
placement="bottom"
2326
style="display: block;"
2427
tabindex="0">
2528
<svg class="bx--overflow-menu__icon" width="3" height="15" viewBox="0 0 3 15">

0 commit comments

Comments
 (0)