Skip to content

Commit 4b8bd65

Browse files
committed
Remove brackets and update tabIndex
1 parent b4863bc commit 4b8bd65

File tree

3 files changed

+11
-14
lines changed

3 files changed

+11
-14
lines changed

src/dialog/overflow-menu/overflow-menu-pane.component.ts

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export class OverflowMenuPane extends Dialog {
4646
const listItems = this.listItems();
4747

4848
switch (event.key) {
49-
case "ArrowDown": {
49+
case "ArrowDown":
5050
event.preventDefault();
5151
if (!isFocusInLastItem(event, listItems)) {
5252
const index = listItems.findIndex(item => item === event.target);
@@ -55,9 +55,9 @@ export class OverflowMenuPane extends Dialog {
5555
listItems[0].focus();
5656
}
5757
break;
58-
}
5958

60-
case "ArrowUp": {
59+
case "Up": // IE specific value
60+
case "ArrowUp":
6161
event.preventDefault();
6262
if (!isFocusInFirstItem(event, listItems)) {
6363
const index = listItems.findIndex(item => item === event.target);
@@ -66,24 +66,21 @@ export class OverflowMenuPane extends Dialog {
6666
listItems[listItems.length - 1].focus();
6767
}
6868
break;
69-
}
7069

71-
case "Home": {
70+
case "Home":
7271
event.preventDefault();
7372
listItems[0].focus();
7473
break;
75-
}
7674

77-
case"End": {
75+
case"End":
7876
event.preventDefault();
7977
listItems[listItems.length - 1].focus();
8078
break;
81-
}
8279

8380
case "Enter":
84-
case " ": {
81+
case " ":
8582
this.doClose();
86-
}
83+
break;
8784
}
8885
}
8986

src/dialog/overflow-menu/overflow-menu.component.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,9 @@ import { Component } from "@angular/core";
2020
[appendToBody]="true"
2121
placement="bottom"
2222
class="bx--overflow-menu"
23-
style="display: block;">
24-
<svg class="bx--overflow-menu__icon" width="3" height="15" viewBox="0 0 3 15" tabindex="0">
23+
style="display: block;"
24+
tabindex="0">
25+
<svg class="bx--overflow-menu__icon" width="3" height="15" viewBox="0 0 3 15">
2526
<g fill-rule="evenodd">
2627
<circle cx="1.5" cy="1.5" r="1.5" />
2728
<circle cx="1.5" cy="7.5" r="1.5" />

src/dialog/overflow-menu/overflow-menu.directive.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,9 @@ export class OverflowMenuDirective extends DialogDirective {
5757
hostkeys(event: KeyboardEvent) {
5858
switch (event.key) {
5959
case "Enter":
60-
case " ": {
60+
case " ":
6161
this.toggle();
6262
break;
63-
}
6463
}
6564
}
6665
}

0 commit comments

Comments
 (0)