Skip to content

Commit 4d4c84e

Browse files
authored
Merge pull request #2598 from Akshat55/navigation-fix
fix: Update css classes
2 parents dfcc603 + 842727e commit 4d4c84e

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

src/ui-shell/sidenav/sidenav-item.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import { Router } from "@angular/router";
1919
<a
2020
class="cds--side-nav__link"
2121
[ngClass]="{
22-
'cds--side-nav__link--current': active
22+
'cds--side-nav__item--active': active
2323
}"
2424
[href]="href"
2525
[attr.aria-current]="(active ? 'page' : null)"

src/ui-shell/sidenav/sidenav.component.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,10 @@ import { NavigationItem } from "../header/header-navigation-items.interface";
1515
@Component({
1616
selector: "cds-sidenav, ibm-sidenav",
1717
template: `
18-
<nav class="cds--side-nav__navigation" [attr.aria-label]="ariaLabel">
18+
<nav class="cds--side-nav__items" [attr.aria-label]="ariaLabel">
1919
<ng-content select="cds-sidenav-header"></ng-content>
20-
<div class="cds--side-nav__items" role="list">
21-
<div
22-
class="cds--side-nav__header-navigation cds--side-nav__header-divider">
20+
<div role="list">
21+
<div class="cds--side-nav__header-navigation cds--side-nav__header-divider">
2322
<ng-container *ngFor="let navigationItem of navigationItems">
2423
<cds-sidenav-item
2524
*ngIf="navigationItem.type === 'item'"
@@ -82,7 +81,7 @@ import { NavigationItem } from "../header/header-navigation-items.interface";
8281
})
8382
export class SideNav {
8483
@HostBinding("class.cds--side-nav") hostClass = true;
85-
@HostBinding("attr.aria-label") @Input() ariaLabel = "Side navigation";
84+
@Input() ariaLabel = "Side navigation";
8685
/**
8786
* Controls the expanded (`true`) or collapsed (`false`) state when on a small screen.
8887
*/
@@ -92,7 +91,7 @@ export class SideNav {
9291
*/
9392
@HostBinding("class.cds--side-nav--hidden") @Input() hidden = false;
9493
@HostBinding("class.cds--side-nav--rail") @Input() rail = false;
95-
@HostBinding("class.cds--side-nav--ux") ux = true;
94+
@HostBinding("class.cds--side-nav__navigation") ux = true;
9695
@Input() allowExpansion = false;
9796

9897
/**

src/ui-shell/ui-shell.stories.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,8 +227,7 @@ const SideNavigationTemplate: Story = (args) => ({
227227
template: `
228228
<div [cdsTheme]="theme">
229229
<cds-sidenav>
230-
<cds-sidenav-item>
231-
<svg cdsIcon="fade" size="16"></svg>
230+
<cds-sidenav-item [active]="true">
232231
Link
233232
</cds-sidenav-item>
234233
<cds-sidenav-item>

0 commit comments

Comments
 (0)