Skip to content

Commit 50e170a

Browse files
authored
Merge pull request #2602 from Akshat55/localization
fix: Remove unused localization
2 parents 1413626 + af8d8a5 commit 50e170a

File tree

2 files changed

+16
-79
lines changed

2 files changed

+16
-79
lines changed

src/i18n/en.ts

Lines changed: 7 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,7 @@
11
export default {
2-
"BANNER": {
3-
"CLOSE_BUTTON": "Close alert banner"
4-
},
52
"BREADCRUMB": {
63
"LABEL": "Breadcrumb"
74
},
8-
"CALENDAR": {
9-
"MONTHS": {
10-
"JANUARY": "January",
11-
"FEBRUARY": "February",
12-
"MARCH": "March",
13-
"APRIL": "April",
14-
"MAY": "May",
15-
"JUNE": "June",
16-
"JULY": "July",
17-
"AUGUST": "August",
18-
"SEPTEMBER": "September",
19-
"OCTOBER": "October",
20-
"NOVEMBER": "November",
21-
"DECEMBER": "December"
22-
},
23-
"SHORTWEEKDAYS": {
24-
"SUNDAY": "Sun",
25-
"MONDAY": "Mon",
26-
"TUESDAY": "Tue",
27-
"WEDNESDAY": "Wed",
28-
"THURSDAY": "Thu",
29-
"FRIDAY": "Fri",
30-
"SATURDAY": "Sat"
31-
},
32-
"QUARTERS":
33-
[
34-
{
35-
"name": "Q1",
36-
"months": "January-March"
37-
}
38-
,
39-
{
40-
"name": "Q2",
41-
"months": "April-June"
42-
},
43-
{
44-
"name": "Q3",
45-
"months": "July-September"
46-
},
47-
{
48-
"name": "Q4",
49-
"months": "October-December"
50-
}
51-
]
52-
},
535
"CODE_SNIPPET": {
546
"CODE_SNIPPET_TEXT": "Code Snippet Text",
557
"SHOW_MORE": "Show more",
@@ -63,20 +15,15 @@ export default {
6315
"CLEAR_SELECTIONS": "Clear all selected items",
6416
"CLEAR_SELECTED": "Clear selected item",
6517
"A11Y": {
66-
"OPEN_MENU": "open menu",
67-
"CLOSE_MENU": "close menu",
18+
"OPEN_MENU": "Open menu",
19+
"CLOSE_MENU": "Close menu",
6820
"CLEAR_SELECTIONS": "Clear all selected items",
6921
"CLEAR_SELECTED": "Clear Selection"
7022
}
7123
},
72-
"DIALOG": {
73-
"POPOVER" : {
74-
"CLOSE": "Close popover"
75-
}
76-
},
7724
"DROPDOWN": {
7825
"OPEN": "Open menu",
79-
"SELECTED": "selected",
26+
"SELECTED": "Selected",
8027
"CLEAR": "Clear all selected items",
8128
"FILTER": {
8229
"SELECTED_ONLY": "Show selected only",
@@ -90,10 +37,8 @@ export default {
9037
},
9138
"FILE_UPLOADER": {
9239
"CHECKMARK": "Checkmark",
93-
"CHECKMARK_TITLE": "File uploaded!",
9440
"OPEN": "Add file",
95-
"REMOVE_BUTTON": "Close button",
96-
"REMOVE_TITLE": "Delete File"
41+
"REMOVE_BUTTON": "Close button"
9742
},
9843
"LOADING": {
9944
"TITLE": "Loading"
@@ -105,17 +50,16 @@ export default {
10550
"CLOSE_BUTTON": "Close alert notification"
10651
},
10752
"NUMBER": {
108-
"INCREMENT": "increment value",
109-
"DECREMENT": "decrement value"
53+
"INCREMENT": "Increment value",
54+
"DECREMENT": "Decrement value"
11055
},
11156
"OVERFLOW_MENU": {
11257
"OVERFLOW": "Overflow"
11358
},
11459
"SEARCH": {
11560
"LABEL": "Search",
11661
"PLACEHOLDER": "Search",
117-
"CLEAR_BUTTON": "Clear search input",
118-
"TOOLBAR_SEARCH": "Toolbar search"
62+
"CLEAR_BUTTON": "Clear search input"
11963
},
12064
"PAGINATION": {
12165
"ITEMS_PER_PAGE": "Items per page:",
@@ -139,11 +83,6 @@ export default {
13983
"INVALID": "Invalid"
14084
},
14185
"TABLE": {
142-
"GO_TO_PAGE": "Go to page",
143-
"PREVIOUS_PAGE": "Previous page",
144-
"NEXT_PAGE": "Next page",
145-
"PREVIOUS_3": "Scroll to previous 3 pages",
146-
"NEXT_3": "Scroll to next 3 pages",
14786
"FILTER": "Filter",
14887
"END_OF_DATA": "You've reached the end of your content",
14988
"SCROLL_TOP": "Scroll to top",
@@ -182,8 +121,6 @@ export default {
182121
"CLOSE_MENU": "Close menu"
183122
},
184123
"SIDE_NAV": {
185-
"LABEL": "Side navigation",
186-
"SWITCHER": "Switcher",
187124
"TOGGLE_OPEN": "Open",
188125
"TOGGLE_CLOSE": "Close"
189126
}

src/i18n/i18n.spec.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,27 +11,27 @@ describe("i18n service", () => {
1111
});
1212

1313
it("should translate a string", done => {
14-
service.get("BANNER.CLOSE_BUTTON").subscribe(value => {
15-
expect(value).toBe(EN.BANNER.CLOSE_BUTTON);
14+
service.get("CODE_SNIPPET.COPIED").subscribe(value => {
15+
expect(value).toBe(EN.CODE_SNIPPET.COPIED);
1616
done();
1717
});
1818
});
1919

2020
it("should update strings", done => {
21-
service.set({ "BANNER": { "CLOSE_BUTTON": "test" }});
21+
service.set({ "CODE_SNIPPET": { "COPIED": "test" }});
2222

23-
service.get("BANNER.CLOSE_BUTTON").subscribe(value => {
23+
service.get("CODE_SNIPPET.COPIED").subscribe(value => {
2424
expect(value).toBe("test");
2525
done();
2626
});
2727
});
2828

2929
it("should emit updated string", () => {
30-
const subject = service.get("BANNER.CLOSE_BUTTON");
30+
const subject = service.get("CODE_SNIPPET.COPIED");
3131

3232
const spy = spyOn(subject, "next");
3333

34-
service.set({ "BANNER": { "CLOSE_BUTTON": "test" } });
34+
service.set({ "CODE_SNIPPET": { "COPIED": "test" } });
3535

3636
expect(spy).toHaveBeenCalled();
3737
});
@@ -73,10 +73,10 @@ describe("i18n service", () => {
7373
});
7474

7575
it("should keep the default translation strings", () => {
76-
service.set({ "BANNER": { "TEST": "TEST" } });
76+
service.set({ "CODE_SNIPPET": { "TEST": "TEST" } });
7777

78-
expect(service.get().BANNER.CLOSE_BUTTON).toBe(EN.BANNER.CLOSE_BUTTON);
79-
expect(service.get().BANNER.TEST).toBe("TEST");
78+
expect(service.get().CODE_SNIPPET.COPIED).toBe(EN.CODE_SNIPPET.COPIED);
79+
expect(service.get().CODE_SNIPPET.TEST).toBe("TEST");
8080
});
8181

8282
it("should return a whole subtree as observables", () => {

0 commit comments

Comments
 (0)