You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
And set up our translations in `src/app/app.module.ts`:
32
+
> *Note:* For offline usage we'll need to set `$font-path: '~carbon-components/src/globals/fonts';` at the very top of our `src/styles.scss`. This will copy the fonts to our `dist` folder upon successful build. If you like the fonts to be a part of your `assets` folder and not pollute the `dist` folder then copy the fonts from `node_modules/carbon-components/src/globals/fonts` into our app's `src/assets/fonts` folder and add `$font-path: '/assets/fonts/';` at the very top of our `src/styles.scss`.
33
+
34
+
Then set up our translations in `src/app/app.module.ts`:
@@ -44,7 +45,6 @@ import { AppComponent } from './app.component';
44
45
],
45
46
imports: [
46
47
BrowserModule,
47
-
TranslateModule.forRoot()
48
48
],
49
49
providers: [],
50
50
bootstrap: [AppComponent]
@@ -80,7 +80,7 @@ _Finally_ we can run `npm start` and start building out our application!
80
80
- attach a screenshot (or a gif!) for design reference if needed
81
81
- reference the related issue
82
82
- "closes #123" or "fixes #123" will close issue #123 once the PR is merged
83
-
- "issue #123" just refences the issue. Only use this if you definitly need the issue to remain open.
83
+
- "issue #123" just references the issue. Only use this if you definitely need the issue to remain open.
84
84
-@mention any specific other developers that need to be aware of the changes
85
85
- add the "needs review" label along with any other relevant labels
86
86
-[link to code review checklist goes here](#)
@@ -97,11 +97,11 @@ _Finally_ we can run `npm start` and start building out our application!
97
97
- screenshots if needed
98
98
- relevant code snippets
99
99
- links to application source code or running demo ([Codesandbox is awesome for this!](https://codesandbox.io/s/angular)) (including connection/authentication information)
- if you have a fix to contribute, assign yourself, otherwise leave unassigned
102
102
103
103
#### npm commands
104
-
To keep our build dependancies local we use npm scripts to run our webpack, gulp, and general build tasks. You should never install webpack or gulp globally as that will likely conflict with our version. You should never need to modify the build process to add a component or story.
104
+
To keep our build dependencies local we use npm scripts to run our webpack, gulp, and general build tasks. You should never install webpack or gulp globally as that will likely conflict with our version. You should never need to modify the build process to add a component or story.
105
105
-`npm run storybook` to run storybook (port 6006)
106
106
-`npm run build` to generate the dist
107
107
-`docs:build` to build documentation
@@ -113,7 +113,9 @@ To keep our build dependancies local we use npm scripts to run our webpack, gulp
0 commit comments