Merge pull request #2617 from Akshat55/icon-ng-onchange

fix: check if cdsIcon value is truthy

Author: Akshat55

src/icon/icon.directive.ts

@@ -126,7 +126,7 @@ export class IconDirective implements AfterViewInit, OnChanges {
 	ngOnChanges({ cdsIcon }: SimpleChanges) {
 		// We want to ignore first change to let the icon register
 		// and add only after view has been initialized
-		if (!cdsIcon.isFirstChange()) {
+		if (cdsIcon && !cdsIcon.isFirstChange()) {
 			this.renderIcon(this.cdsIcon);
 		}
 	}

src/input/label.component.ts

@@ -93,13 +93,13 @@ import { TextInput } from "./input.directive";
 				#wrapper>
 				<svg
 					*ngIf="!warn && invalid"
-					ibmIcon="warning--filled"
+					cdsIcon="warning--filled"
 					size="16"
 					class="cds--text-input__invalid-icon">
 				</svg>
 				<svg
 					*ngIf="!invalid && warn"
-					ibmIcon="warning--alt--filled"
+					cdsIcon="warning--alt--filled"
 					size="16"
 					class="cds--text-input__invalid-icon cds--text-input__invalid-icon--warning">
 				</svg>

src/input/text-input-label.component.ts

@@ -34,13 +34,13 @@ import {
 			#wrapper>
 			<svg
 				*ngIf="!warn && invalid"
-				ibmIcon="warning--filled"
+				cdsIcon="warning--filled"
 				size="16"
 				class="cds--text-input__invalid-icon">
 			</svg>
 			<svg
 				*ngIf="!invalid && warn"
-				ibmIcon="warning--alt--filled"
+				cdsIcon="warning--alt--filled"
 				size="16"
 				class="cds--text-input__invalid-icon cds--text-input__invalid-icon--warning">
 			</svg>