Merge pull request #235 from zvonimirfras/master

fix(dialog): add singleton click listener for safari fix

Author: zvonimirfras

src/dialog/dialog.directive.ts

@@ -135,7 +135,7 @@ export class DialogDirective implements OnInit, OnDestroy, OnChanges {
 	 */
 	ngOnInit() {
 		// fix for safari hijacking clicks
-		document.body.firstElementChild.addEventListener("click", () => null, true);
+		this.dialogService.singletonClickListen();
 
 		// bind events for hovering or clicking the host
 		if (this.trigger === "hover" || this.trigger === "mouseenter") {

src/dialog/dialog.service.ts

@@ -18,6 +18,11 @@ import { PlaceholderService } from "./../placeholder/placeholder.module";
  */
 @Injectable()
 export class DialogService {
+	/**
+	 * Used in `singletonClickListen`, don't count on its existence and values.
+	 */
+	private static listeningForBodyClicks = false;
+
 	/**
 	 * Reflects the open or closed state of the `Dialog`.
 	 * @memberof DialogService
@@ -157,4 +162,23 @@ export class DialogService {
 			}
 		}
 	}
+
+	/**
+	 * Fix for safari hijacking clicks.
+	 *
+	 * Runs on `ngOnInit` of every dialog. Ensures we don't have multiple listeners
+	 * because having many of them could degrade performance in certain cases (and is
+	 * not necessary for our use case)
+	 *
+	 * This is an internally used function, can change at any point (even get removed)
+	 * and changes to it won't be considered a breaking change. Use at your own risk.
+	 */
+	singletonClickListen() {
+		console.log("singleton");
+		if (!DialogService.listeningForBodyClicks) {
+			console.log("singleton click");
+			document.body.firstElementChild.addEventListener("click", () => null, true);
+			DialogService.listeningForBodyClicks = true;
+		}
+	}
 }