Skip to content

Commit 98f0b26

Browse files
committed
issue #163: review feedback
1 parent 83a2e74 commit 98f0b26

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

src/dropdown/dropdown.component.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@ import { I18n } from "./../i18n/i18n.module";
3030
template: `
3131
<div
3232
class="bx--list-box"
33-
[ngClass]="{'bx--dropdown--light': light}"
34-
>
33+
[ngClass]="{'bx--dropdown--light': theme === 'light'}">
3534
<button
3635
type="button"
3736
#dropdownButton
@@ -86,10 +85,10 @@ export class Dropdown implements OnInit, AfterContentInit, OnDestroy {
8685
*/
8786
@Input() type: "single" | "multi" = "single";
8887
/**
89-
* Set to `true` to apply the light style to the dropdown.
88+
* `light` or `dark` dropdown theme
9089
* @memberof Dropdown
9190
*/
92-
@Input() light = false;
91+
@Input() theme: "light" | "dark" = "dark";
9392
/**
9493
* Set to `true` to disable the dropdown.
9594
*/

src/dropdown/dropdown.stories.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ storiesOf("Dropdown", module)
4444
.add("Light", () => ({
4545
template: `
4646
<ibm-dropdown
47-
[light]="true"
47+
[theme]="'light'"
4848
placeholder="Select"
4949
[disabled]="disabled"
5050
(selected)="selected($event)"

0 commit comments

Comments
 (0)