Skip to content

Commit 9c0491d

Browse files
committed
fix(combobox): fixes #110
1 parent cc78623 commit 9c0491d

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/combobox/combobox.component.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,14 +61,11 @@ import { NG_VALUE_ACCESSOR } from "@angular/forms";
6161
</div>
6262
<input
6363
[disabled]="disabled"
64-
[attr.aria-expanded]="open"
6564
(click)="toggleDropdown()"
6665
(keyup)="onSearch($event.target.value)"
6766
[value]="selectedValue"
6867
class="bx--text-input"
6968
aria-label="ListBox input field"
70-
role="combobox"
71-
aria-autocomplete="list"
7269
autocomplete="off"
7370
placeholder="Filter..."/>
7471
<div
@@ -200,7 +197,7 @@ export class ComboBox implements OnChanges, OnInit, AfterViewInit, AfterContentI
200197
@ContentChild(AbstractDropdownView) view: AbstractDropdownView;
201198
@ViewChild("dropdownMenu") dropdownMenu;
202199
@HostBinding("class") class = "bx--combo-box bx--list-box";
203-
@HostBinding("attr.role") role = "listbox";
200+
@HostBinding("attr.role") role = "combobox";
204201
@HostBinding("style.display") display = "block";
205202

206203
public open = false;

src/dropdown/dropdown.component.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,12 @@ import {
99
ViewChild,
1010
AfterContentInit,
1111
HostListener,
12-
OnDestroy,
12+
OnDestroy
1313
} from "@angular/core";
1414
import { NG_VALUE_ACCESSOR } from "@angular/forms";
1515

16-
import { fromEvent, of, Subscription } from "rxjs";
16+
// Observable import is required here so typescript can compile correctly
17+
import { Observable, fromEvent, of, Subscription } from "rxjs";
1718
import { throttleTime } from "rxjs/operators";
1819

1920
import { TranslateService } from "@ngx-translate/core";

0 commit comments

Comments
 (0)