Skip to content

Commit 9d33784

Browse files
authored
Merge branch 'master' into issue-2550
2 parents 6d01962 + 2b1984a commit 9d33784

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

src/ui-shell/sidenav/sidenav-item.component.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@ import { Router } from "@angular/router";
2323
<a
2424
class="bx--side-nav__link"
2525
[href]="href"
26+
[ngClass]="{
27+
'bx--side-nav__link--current': active
28+
}"
2629
[attr.role]="(isSubMenu ? 'menuitem' : null)"
2730
[attr.aria-current]="(active ? 'page' : null)"
2831
[attr.title]="title ? title : null"

src/ui-shell/sidenav/sidenav-menu.component.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import { SideNavItemInterface } from "./sidenav-item.interface";
2727
[attr.aria-expanded]="expanded"
2828
type="button">
2929
<div class="bx--side-nav__icon">
30-
<ng-content select="[icon]"></ng-content>
30+
<ng-content select="svg, [icon]"></ng-content>
3131
</div>
3232
<span class="bx--side-nav__submenu-title">{{title}}</span>
3333
<div class="bx--side-nav__icon bx--side-nav__icon--small bx--side-nav__submenu-chevron">
@@ -113,10 +113,6 @@ export class SideNavMenu implements AfterContentInit, OnDestroy {
113113
}
114114

115115
protected findActiveChildren() {
116-
if (this.sidenavItems.some(item => item.active)) {
117-
this.hasActiveChild = true;
118-
} else {
119-
this.hasActiveChild = false;
120-
}
116+
this.hasActiveChild = this.sidenavItems.some(item => item.active);
121117
}
122118
}

src/ui-shell/ui-shell.stories.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ storiesOf("Components|UI Shell", module)
202202
.add("Side Navigation", () => ({
203203
template: `
204204
<ibm-sidenav>
205-
<ibm-sidenav-item>
205+
<ibm-sidenav-item active="true">
206206
<svg ibmIcon="fade" size="16"></svg>
207207
Link
208208
</ibm-sidenav-item>
@@ -212,7 +212,7 @@ storiesOf("Components|UI Shell", module)
212212
</ibm-sidenav-item>
213213
<ibm-sidenav-menu title="Category title">
214214
<svg ibmIcon="fade" size="16"></svg>
215-
<ibm-sidenav-item>Link</ibm-sidenav-item>
215+
<ibm-sidenav-item active="true">Link</ibm-sidenav-item>
216216
<ibm-sidenav-item>Link</ibm-sidenav-item>
217217
<ibm-sidenav-item>Link</ibm-sidenav-item>
218218
</ibm-sidenav-menu>

0 commit comments

Comments
 (0)