Skip to content

Commit a67584b

Browse files
Merge branch 'master' into issue-2479
2 parents cdab5e0 + 8b1dff6 commit a67584b

File tree

2 files changed

+22
-10
lines changed

2 files changed

+22
-10
lines changed

src/combobox/combobox.component.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -397,10 +397,12 @@ export class ComboBox implements OnChanges, AfterViewInit, AfterContentInit, OnD
397397
selected: boolean
398398
}
399399
}>();
400-
/** emits an empty event when the menu is closed */
400+
/** Emits an empty event when the menu is closed */
401401
@Output() close = new EventEmitter<void>();
402-
/** emits the search string from the input */
402+
/** Emits the search string from the input */
403403
@Output() search = new EventEmitter<string>();
404+
/** Emits an event when the clear button is clicked. */
405+
@Output() clear = new EventEmitter();
404406
/** ContentChild reference to the instantiated dropdown list */
405407
// @ts-ignore
406408
@ContentChild(AbstractDropdownView, { static: true }) view: AbstractDropdownView;
@@ -676,6 +678,7 @@ export class ComboBox implements OnChanges, AfterViewInit, AfterContentInit, OnD
676678
const selected = this.view.getSelected();
677679
this.propagateChangeCallback(selected);
678680
this.selected.emit(selected as any);
681+
this.clear.emit();
679682
}
680683

681684
/**

src/combobox/combobox.stories.ts

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ const getOptions = (override = {}) => {
4040
submit: action("submit"),
4141
size: select("size", ["sm", "md", "xl"], "md"),
4242
theme: select("theme", ["dark", "light"], "dark"),
43-
search: action("search")
43+
search: action("search"),
44+
clear: action("clear fired!")
4445
};
4546

4647
return Object.assign({}, options, override);
@@ -74,7 +75,8 @@ const modalText =
7475
<ibm-combo-box
7576
[(items)]="items"
7677
type="multi"
77-
(selected)="updateSelected($event)">
78+
(selected)="updateSelected($event)"
79+
(clear)="clear()">
7880
<ibm-dropdown-list></ibm-dropdown-list>
7981
</ibm-combo-box>
8082
`
@@ -293,7 +295,8 @@ storiesOf("Components|Combobox", module)
293295
[theme]="theme"
294296
(selected)="selected($event)"
295297
(submit)="submit($event)"
296-
(search)="search($event)">
298+
(search)="search($event)"
299+
(clear)="clear()">
297300
<ibm-dropdown-list></ibm-dropdown-list>
298301
</ibm-combo-box>
299302
`,
@@ -324,6 +327,7 @@ storiesOf("Components|Combobox", module)
324327
[theme]="theme"
325328
(selected)="selected($event)"
326329
(submit)="submit($event)"
330+
(clear)="clear()"
327331
[maxLength]="maxLength">
328332
<ibm-dropdown-list></ibm-dropdown-list>
329333
</ibm-combo-box>
@@ -347,7 +351,8 @@ storiesOf("Components|Combobox", module)
347351
[items]="items"
348352
[theme]="theme"
349353
(selected)="onSelected()"
350-
(search)="onSearch($event)">
354+
(search)="onSearch($event)"
355+
(clear)="clear()">
351356
<ibm-dropdown-list></ibm-dropdown-list>
352357
</ibm-combo-box>
353358
</div>
@@ -382,7 +387,8 @@ storiesOf("Components|Combobox", module)
382387
[items]="items"
383388
[theme]="theme"
384389
(selected)="onSelected()"
385-
(search)="onSearch($event)">
390+
(search)="onSearch($event)"
391+
(clear)="clear()">
386392
<ibm-dropdown-list></ibm-dropdown-list>
387393
</ibm-combo-box>
388394
@@ -425,7 +431,8 @@ storiesOf("Components|Combobox", module)
425431
[selectionFeedback]="selectionFeedback"
426432
type="multi"
427433
(selected)="selected($event)"
428-
(submit)="submit($event)">
434+
(submit)="submit($event)"
435+
(clear)="clear()">
429436
<ibm-dropdown-list></ibm-dropdown-list>
430437
</ibm-combo-box>
431438
</div>
@@ -472,7 +479,8 @@ storiesOf("Components|Combobox", module)
472479
[size]="size"
473480
type="multi"
474481
(selected)="selected($event)"
475-
(submit)="submit($event)">
482+
(submit)="submit($event)"
483+
(clear)="clear()">
476484
<ibm-dropdown-list></ibm-dropdown-list>
477485
</ibm-combo-box>
478486
</div>
@@ -507,7 +515,8 @@ storiesOf("Components|Combobox", module)
507515
[theme]="theme"
508516
[(ngModel)]="model"
509517
(selected)="selected($event)"
510-
(submit)="submit($event)">
518+
(submit)="submit($event)"
519+
(clear)="clear()">
511520
<ibm-dropdown-list></ibm-dropdown-list>
512521
</ibm-combo-box>
513522

0 commit comments

Comments
 (0)