Skip to content

Commit abeac0d

Browse files
committed
Merge
2 parents ce54a1a + 40e5148 commit abeac0d

38 files changed

+1037
-664
lines changed

.storybook/preview.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
@import "~carbon-components/scss/globals/scss/styles.scss";
1+
@import "~carbon-components/css/carbon-components.min.css";
22

33
body {
44
margin: 20px;

.storybook/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"emitDecoratorMetadata": true,
66
"experimentalDecorators": true,
77
"lib": [
8-
"es2015",
8+
"es2016",
99
"dom"
1010
],
1111
"sourceMap": true,

package-lock.json

Lines changed: 216 additions & 207 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,16 @@
1313
"test:watch": "karma start --auto-watch --no-single-run",
1414
"utils:add": "git subtree add --prefix=src/utils [email protected]:peretz/utils.git master --squash",
1515
"utils:update": "git subtree pull --prefix=src/utils [email protected]:peretz/utils.git master --squash",
16-
"prepush": "bash scripts/prepush.sh",
1716
"build-storybook": "build-storybook -c .storybook -s .storybook/public -o dist/docs/storybook",
1817
"semantic-release": "semantic-release",
19-
"commitmsg": "commitlint -E GIT_PARAMS",
2018
"commit": "git-cz"
2119
},
20+
"husky": {
21+
"hooks": {
22+
"pre-push": "bash scripts/prepush.sh",
23+
"commit-msg": "commitlint -E HUSKY_GIT_PARAMS"
24+
}
25+
},
2226
"release": {
2327
"pkgRoot": "dist"
2428
},
@@ -63,7 +67,7 @@
6367
"core-js": "^2.5.3",
6468
"rxjs": "^6.0.0",
6569
"zone.js": "^0.8.26",
66-
"carbon-components": "^9.1.13"
70+
"carbon-components": "^9.20.0"
6771
},
6872
"devDependencies": {
6973
"@angular-devkit/build-angular": "0.7.1",
@@ -93,7 +97,7 @@
9397
"@types/node": "8.5.2",
9498
"angular2-template-loader": "0.6.2",
9599
"babel-core": "6.26.3",
96-
"carbon-components": "9.1.13",
100+
"carbon-components": "9.20.0",
97101
"codelyzer": "4.0.2",
98102
"commitizen": "2.10.1",
99103
"core-js": "2.5.5",
@@ -108,7 +112,7 @@
108112
"gulp-tap": "1.0.1",
109113
"html-loader": "0.5.5",
110114
"html-webpack-plugin": "3.2.0",
111-
"husky": "0.14.3",
115+
"husky": "^1.1.2",
112116
"jasmine-core": "3.1.0",
113117
"karma": "2.0.2",
114118
"karma-chrome-launcher": "2.2.0",

src/accordion/accordion-item.component.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,19 @@ import {
2929
`
3030
})
3131
export class AccordionItem {
32-
static accodionItemCount = 0;
33-
@Input() title = `Title ${AccordionItem.accodionItemCount}`;
34-
@HostBinding("class.bx--accordion__item--active") @Input() expanded = false;
35-
@Input() id = `accordion-item-${AccordionItem.accodionItemCount}`;
32+
static accordionItemCount = 0;
33+
@Input() title = `Title ${AccordionItem.accordionItemCount}`;
34+
@Input() id = `accordion-item-${AccordionItem.accordionItemCount}`;
3635
@Output() selected = new EventEmitter();
3736

38-
@HostBinding("class") itemClass = "bx--accordion__item";
39-
@HostBinding("style.display") @HostBinding("attr.role") itemType = "list-item";
37+
@HostBinding("class.bx--accordion__item") itemClass = true;
38+
@HostBinding("class.bx--accordion__item--active") @Input() expanded = false;
39+
@HostBinding("style.display") itemType = "list-item";
40+
@HostBinding("attr.role") role = "heading";
41+
@HostBinding("attr.aria-level") @Input() ariaLevel = 3;
4042

4143
constructor() {
42-
AccordionItem.accodionItemCount++;
44+
AccordionItem.accordionItemCount++;
4345
}
4446

4547
public toggleExpanded() {

src/dialog/dialog.component.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ import {
1717
merge
1818
} from "rxjs";
1919
import { throttleTime } from "rxjs/operators";
20-
import position from "../utils/position";
20+
// the AbsolutePosition is required to import the declaration correctly
21+
import position, { AbsolutePosition } from "./../utils/position";
2122
import { cycleTabs } from "./../common/tab.service";
2223
import { DialogConfig } from "./dialog-config.interface";
2324

src/i18n/en.json

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"TOOLTIP": {
5252
"CLOSE": "Close tooltip"
5353
},
54-
"POPOVER" : {
54+
"POPOVER": {
5555
"CLOSE": "Close popover"
5656
}
5757
},
@@ -65,12 +65,19 @@
6565
"RESET_SEARCH": "Reset search"
6666
}
6767
},
68-
"MODAL" : {
68+
"MODAL": {
6969
"CLOSE": "Close modal"
7070
},
71-
"OVERFLOW_MENU" : {
71+
"OVERFLOW_MENU": {
7272
"OVERFLOW": "Overflow"
7373
},
74+
"PAGINATION": {
75+
"ITEMS_PER_PAGE": "Items per page:",
76+
"OPEN_LIST_OF_OPTIONS": "Open list of options",
77+
"ITEMS_INDICES": "{{startItemIndex}}-{{endItemIndex}} of {{totalDataLength}} items",
78+
"BACKWARD": "Backward",
79+
"FORWARD": "Forward"
80+
},
7481
"SIDENAV": {
7582
"NAV_LABEL": "Side navigation"
7683
},

src/input/input.directive.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { Directive, HostBinding } from "@angular/core";
55
*
66
* Example:
77
*
8-
* ```hmtl
8+
* ```html
99
* <input ibmText/>
1010
* ```
1111
*

src/input/input.module.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,18 @@ import { CommonModule } from "@angular/common";
66
// imports
77
import { LabelComponent } from "./label.component";
88
import { TextInput } from "./input.directive";
9+
import { TextArea } from "./text-area.directive";
910

1011
@NgModule({
1112
declarations: [
1213
LabelComponent,
13-
TextInput
14+
TextInput,
15+
TextArea
1416
],
1517
exports: [
1618
LabelComponent,
17-
TextInput
19+
TextInput,
20+
TextArea
1821
],
1922
imports: [
2023
CommonModule,

src/input/input.stories.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,8 @@ storiesOf("Input", module).addDecorator(
2222
template: `
2323
<input ibmText placeholder="Optional placeholder text"/>
2424
`
25+
})).add("TextArea", () => ({
26+
template: `
27+
<textarea ibmTextArea placeholder="Optional placeholder text" rows="4" cols="50"></textarea>
28+
`
2529
}));

0 commit comments

Comments
 (0)