Skip to content

Commit bca0c4f

Browse files
authored
Merge pull request #232 from zvonimirfras/master
Fix typos in readme
2 parents 4076ef2 + 4fd8756 commit bca0c4f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Then we need to include carbon-components in `src/styles.scss`:
1717
@import "~carbon-components/scss/globals/scss/styles.scss";
1818
```
1919

20-
> *Note:* For offline usage we'll need to set `$font-path: '~carbon-components/src/globals/fonts';` at the very top of our `src/styles.scss`. This will copy the fonts to our `dist` folder upon successful build. If you like the fonts to be a part of your `assets` folder and not polute the `dist` folder then copy the fonts from `node_modules/carbon-components/src/globals/fonts` into our app's `src/assets/fonts` folder and add `$font-path: '/assets/fonts/';` at the very top of our `src/styles.scss`.
20+
> *Note:* For offline usage we'll need to set `$font-path: '~carbon-components/src/globals/fonts';` at the very top of our `src/styles.scss`. This will copy the fonts to our `dist` folder upon successful build. If you like the fonts to be a part of your `assets` folder and not pollute the `dist` folder then copy the fonts from `node_modules/carbon-components/src/globals/fonts` into our app's `src/assets/fonts` folder and add `$font-path: '/assets/fonts/';` at the very top of our `src/styles.scss`.
2121
2222
Then set up our translations in `src/app/app.module.ts`:
2323

@@ -66,7 +66,7 @@ _Finally_ we can run `npm start` and start building out our application!
6666
- attach a screenshot (or a gif!) for design reference if needed
6767
- reference the related issue
6868
- "closes #123" or "fixes #123" will close issue #123 once the PR is merged
69-
- "issue #123" just refences the issue. Only use this if you definitly need the issue to remain open.
69+
- "issue #123" just references the issue. Only use this if you definitely need the issue to remain open.
7070
- @mention any specific other developers that need to be aware of the changes
7171
- add the "needs review" label along with any other relevant labels
7272
- [link to code review checklist goes here](#)
@@ -83,11 +83,11 @@ _Finally_ we can run `npm start` and start building out our application!
8383
- screenshots if needed
8484
- relevant code snippets
8585
- links to application source code or running demo ([Codesandbox is awesome for this!](https://codesandbox.io/s/angular)) (including connection/authentication information)
86-
- add relevant labels (bug, accsibility, design, discussion, feature, etc)
86+
- add relevant labels (bug, accessibility, design, discussion, feature, etc)
8787
- if you have a fix to contribute, assign yourself, otherwise leave unassigned
8888

8989
#### npm commands
90-
To keep our build dependancies local we use npm scripts to run our webpack, gulp, and general build tasks. You should never install webpack or gulp globally as that will likely conflict with our version. You should never need to modify the build process to add a component or story.
90+
To keep our build dependencies local we use npm scripts to run our webpack, gulp, and general build tasks. You should never install webpack or gulp globally as that will likely conflict with our version. You should never need to modify the build process to add a component or story.
9191
- `npm run storybook` to run storybook (port 6006)
9292
- `npm run build` to generate the dist
9393
- `docs:build` to build documentation

0 commit comments

Comments
 (0)