Merge pull request #365 from cal-smith/position

fix(position): just use body as a reference

Author: zvonimirfras

src/utils/position.ts

@@ -93,23 +93,15 @@ export namespace position {
 	}
 
 	export function getAbsoluteOffset(target: HTMLElement): Offset {
-		let positionedElement;
 		let currentNode = target;
 		let margins = {
 			top: 0,
 			left: 0
 		};
 
-		// searches either for a parent `positionedElement` or for
-		// containing elements with additional margins
-		// once we have a `positionedElement` we can stop searching
-		// since we use offsetParent we end up skipping most elements
-		while (currentNode.offsetParent && !positionedElement) {
+		// searches for containing elements with additional margins
+		while (currentNode.offsetParent) {
 			const computed = getComputedStyle(currentNode.offsetParent);
-			if (computed.position !== "static") {
-				positionedElement = currentNode.offsetParent;
-			}
-
 			// find static elements with additional margins
 			// since they tend to throw off our positioning
 			// (usually this is just the body)
@@ -129,14 +121,8 @@ export namespace position {
 			currentNode = currentNode.offsetParent as HTMLElement;
 		}
 
-		// if we don't find any `relativeElement` on our walk
-		// default to the body
-		if (!positionedElement) {
-			positionedElement = document.body;
-		}
-
 		const targetRect = target.getBoundingClientRect();
-		const relativeRect = positionedElement.getBoundingClientRect();
+		const relativeRect = document.body.getBoundingClientRect();
 		return {
 			top: targetRect.top - relativeRect.top + margins.top,
 			left: targetRect.left - relativeRect.left + margins.left