fix yousefs review comments

Author: cal-smith

package-lock.json

@@ -65,7 +65,7 @@
     "rxjs": "^6.0.0",
     "zone.js": "^0.8.26",
     "carbon-components": "^10.0.0",
-    "@carbon/icons-angular": "^10.0.0"
+    "@carbon/icons-angular": "^10.1.0"
   },
   "devDependencies": {
     "@angular-devkit/build-angular": "0.7.1",
@@ -82,7 +82,7 @@
     "@angular/platform-server": "6.1.0",
     "@angular/router": "6.1.0",
     "@babel/core": "7.4.3",
-    "@carbon/icons-angular": "10.0.0",
+    "@carbon/icons-angular": "10.1.0",
     "@commitlint/cli": "7.5.2",
     "@commitlint/config-conventional": "7.5.0",
     "@compodoc/compodoc": "1.1.9",

package.json

@@ -9,7 +9,8 @@ import { DatePicker } from "./datepicker.component";
 		DatePicker
 	],
 	exports: [
-		DatePicker
+		DatePicker,
+		DatePickerInputModule
 	],
 	imports: [
 		CommonModule,

src/datepicker/datepicker.module.ts

@@ -1,6 +1,12 @@
 import { storiesOf, moduleMetadata } from "@storybook/angular";
 import { action } from "@storybook/addon-actions";
-import { withKnobs, array } from "@storybook/addon-knobs/angular";
+import {
+	withKnobs,
+	array,
+	select,
+	text,
+	boolean
+} from "@storybook/addon-knobs/angular";
 import { DatePickerModule } from "../";
 
 storiesOf("Date Picker", module)
@@ -14,7 +20,6 @@ storiesOf("Date Picker", module)
 	.addDecorator(withKnobs)
 	.add("Simple", () => ({
 		template: `
-		<app-experimental-component></app-experimental-component>
 		<ibm-date-picker-input
 			[theme]="theme"
 			[label]="label"
@@ -86,7 +91,6 @@ storiesOf("Date Picker", module)
 	}))
 	.add("Skeleton", () => ({
 		template: `
-		<app-experimental-component></app-experimental-component>
 		<ibm-date-picker
 			range="true"
 			skeleton="true">

src/datepicker/datepicker.stories.ts

@@ -51,7 +51,9 @@ import {
 		</a>
 
 		<ng-template #tempOutlet>
-			<ng-content></ng-content>
+			<div class="bx--overflow-menu-options__option-content">
+				<ng-content></ng-content>
+			</div>
 		</ng-template>
 	`
 })

src/dialog/overflow-menu/overflow-menu-option.component.ts

@@ -2,13 +2,16 @@ import { storiesOf, moduleMetadata } from "@storybook/angular";
 import { action } from "@storybook/addon-actions";
 import { withKnobs, text, select } from "@storybook/addon-knobs/angular";
 
+import { InformationFilled16Module } from "@carbon/icons-angular/lib/information--filled/16";
 import { DialogModule, PlaceholderModule } from "../../";
 
 storiesOf("Tooltip", module)
 	.addDecorator(
 		moduleMetadata({
 			imports: [
-				DialogModule, PlaceholderModule
+				DialogModule,
+				PlaceholderModule,
+				InformationFilled16Module
 			]
 		})
 	)
@@ -32,10 +35,7 @@ storiesOf("Tooltip", module)
 						trigger="click"
 						[placement]="placement">
 						<div role="button">
-							<svg style="vertical-align: middle;" fill-rule="evenodd" height="16" role="img" viewBox="0 0 16 16" width="16" aria-label="tooltip">
-								<path d="M8 0C3.6 0 0 3.6 0 8s3.6 8 8 8 8-3.6 8-8-3.6-8-8-8zm0 4c.6 0 1 .4 1 1s-.4 1-1 1-1-.4-1-1
-									.4-1 1-1zm2 8H6v-1h1V8H6V7h3v4h1v1z"></path>
-							</svg>
+							<ibm-icon-information-filled16></ibm-icon-information-filled16>
 						</div>
 					</span>
 				</div>

src/dialog/tooltip/tooltip.stories.ts

@@ -17,7 +17,7 @@ const noop = () => {};
 	selector: "ibm-file-uploader",
 	template: `
 		<ng-container *ngIf="!skeleton; else skeletonTemplate">
-			<strong class="bx--label">{{title}}</strong>
+			<strong class="bx--file--label">{{title}}</strong>
 			<p class="bx--label-description">{{description}}</p>
 			<div class="bx--file">
 				<button

src/file-uploader/file-uploader.component.ts

@@ -24,16 +24,15 @@ export class Link {
 
 	/**
 	 * Automatically set to `-1` when link is disabled.
-	 * @memberof Link
 	 */
 	@HostBinding("attr.tabindex") tabindex;
 
 	/**
 	 * Set to true to disable link.
-	 * @memberof Link
 	 */
 	@Input()
 	@HostBinding("attr.aria-disabled")
+	@HostBinding("class.bx--link--disabled")
 	set disabled(disabled: boolean) {
 		this._disabled = disabled;
 		this.tabindex = this.disabled ? -1 : null;

src/link/link.directive.ts

@@ -32,6 +32,7 @@ export class NumberChange {
 	template: `
 		<label *ngIf="skeleton && label" class="bx--label bx--skeleton"></label>
 		<label *ngIf="!skeleton && label" [for]="id" class="bx--label">{{label}}</label>
+		<div *ngIf="helperText" class="bx--form__helper-text">{{helperText}}</div>
 		<div
 			data-numberinput
 			[attr.data-invalid]="(invalid ? '' : null)"
@@ -70,7 +71,6 @@ export class NumberChange {
 			<div *ngIf="invalid" class="bx--form-requirement">
 				{{invalidText}}
 			</div>
-			<div *ngIf="helperText" class="bx--form__helper-text">{{helperText}}</div>
 		</div>
 	`,
 	providers: [

src/number-input/number.component.ts

@@ -75,7 +75,8 @@ import { ExperimentalService } from "./../experimental.module";
 						<option class="bx--select-option" value="50">50</option>
 					</select>
 					<ibm-icon-chevron-down16
-						class="bx--select__arrow"
+						style="display: inherit;"
+						innerClass="bx--select__arrow"
 						[ariaLabel]="optionsListText | async">
 					</ibm-icon-chevron-down16>
 				</div>
@@ -107,7 +108,8 @@ import { ExperimentalService } from "./../experimental.module";
 						<option *ngFor="let i of range(lastPage + 1, 1)" class="bx--select-option" [value]="i">{{i}}</option>
 					</select>
 					<ibm-icon-chevron-down16
-						class="bx--select__arrow"
+						style="display: inherit;"
+						innerClass="bx--select__arrow"
 						[ariaLabel]="optionsListText | async">
 					</ibm-icon-chevron-down16>
 				</div>