Skip to content

fix(side-panel): Parity work#9136

Open
ruchas31 wants to merge 6 commits intocarbon-design-system:mainfrom
ruchas31:sidepanel-8734-8735
Open

fix(side-panel): Parity work#9136
ruchas31 wants to merge 6 commits intocarbon-design-system:mainfrom
ruchas31:sidepanel-8734-8735

Conversation

@ruchas31
Copy link
Contributor

@ruchas31 ruchas31 commented Mar 18, 2026

Closes #8734

About Modal web component parity work

What did you change?

All points in the issue description are addressed except for:

How did you test and verify your work?

Storybook

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request section of
our contributing docs.

@netlify
Copy link

netlify bot commented Mar 18, 2026

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit a478783
🔍 Latest deploy log https://app.netlify.com/projects/ibm-products-web-components/deploys/69bafbb3d1f30300097d60c0
😎 Deploy Preview https://deploy-preview-9136--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 18, 2026

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit a478783
🔍 Latest deploy log https://app.netlify.com/projects/carbon-for-ibm-products/deploys/69bafbb382298b0008993ec9
😎 Deploy Preview https://deploy-preview-9136--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 95.49550% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.77%. Comparing base (fec43b6) to head (a478783).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9136   +/-   ##
=======================================
  Coverage   76.77%   76.77%           
=======================================
  Files         490      490           
  Lines       21759    21855   +96     
  Branches     4676     4684    +8     
=======================================
+ Hits        16706    16780   +74     
- Misses       5053     5075   +22     
Components Coverage Δ
ibm-products 76.83% <ø> (ø)
ibm-products-web-components 76.71% <95.49%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ruchas31 ruchas31 marked this pull request as ready for review March 18, 2026 20:06
@ruchas31 ruchas31 requested a review from a team as a code owner March 18, 2026 20:06
@ruchas31 ruchas31 requested review from amal-k-joy and makafsal and removed request for a team March 18, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Side panel] WC visual parity bug

1 participant