Allow fingerprinting instructions to work for the special InstIds (#6400)

Use the index of the special id instead of crashing.

Fixes #6370.

Author: danakj

toolchain/check/testdata/impl/error_recovery.carbon

@@ -107,6 +107,29 @@ fn G() {
   //@dump-sem-ir-end
 }
 
+// --- fail_invalid_fn_syntax_in_impl.carbon
+library "[[@TEST_NAME]]";
+
+interface I {
+  fn Op[self: Self]();
+}
+
+class C {};
+//@dump-sem-ir-begin
+impl C as I {
+  // This leaves the impl with a placeholder instruction in the witness table.
+  // CHECK:STDERR: fail_invalid_fn_syntax_in_impl.carbon:[[@LINE+8]]:11: error: expected `:` or `:!` in binding pattern [ExpectedBindingPattern]
+  // CHECK:STDERR:   fn Op[x self: C]() {}
+  // CHECK:STDERR:           ^~~~
+  // CHECK:STDERR:
+  // CHECK:STDERR: fail_invalid_fn_syntax_in_impl.carbon:[[@LINE+4]]:11: error: semantics TODO: `handle invalid parse trees in `check`` [SemanticsTodo]
+  // CHECK:STDERR:   fn Op[x self: C]() {}
+  // CHECK:STDERR:           ^~~~
+  // CHECK:STDERR:
+  fn Op[x self: C]() {}
+}
+//@dump-sem-ir-end
+
 // CHECK:STDOUT: --- fail_runtime_generic_param.carbon
 // CHECK:STDOUT:
 // CHECK:STDOUT: constants {
@@ -260,3 +283,10 @@ fn G() {
 // CHECK:STDOUT:   <elided>
 // CHECK:STDOUT: }
 // CHECK:STDOUT:
+// CHECK:STDOUT: --- fail_invalid_fn_syntax_in_impl.carbon
+// CHECK:STDOUT:
+// CHECK:STDOUT: constants {
+// CHECK:STDOUT: }
+// CHECK:STDOUT:
+// CHECK:STDOUT: impl @<null name>: <unexpected>.inst{{[0-9A-F]+}}.loc9_6 as <unexpected>.inst5800002D.loc9_11;
+// CHECK:STDOUT:

toolchain/sem_ir/inst_fingerprinter.cpp

@@ -52,6 +52,12 @@ struct Worklist {
     if (store.size() == 0) {
       return 0;
     }
+    // These InstIds are constant values, so not in the ValueStore. We use a
+    // constant (negative) fingerprint for them.
+    if (inst_id == InstId::InitTombstone ||
+        inst_id == InstId::ImplWitnessTablePlaceholder) {
+      return inst_id.index;
+    }
     return store.Get(inst_id);
   }