When looking up a name in a scope, propagate the lookup result when it's poisoned (#4851)

bricknerb · web-flow · commit 51d7e6315e8a · 2025-01-28T17:45:24.000Z
Instead of creating a new poisoned result. This would allow propagating the poisoning location when we add it. Part of #4622.
diff --git a/toolchain/check/context.cpp b/toolchain/check/context.cpp
@@ -431,9 +431,8 @@ auto Context::LookupNameInExactScope(SemIRLoc loc, SemIR::NameId name_id,
     auto lookup_result = scope.GetEntry(*entry_id).result;
     if (!lookup_result.is_poisoned()) {
       LoadImportRef(*this, lookup_result.target_inst_id());
-      return lookup_result;
     }
-    return SemIR::ScopeLookupResult::MakePoisoned();
+    return lookup_result;
   }
 
   if (!scope.import_ir_scopes().empty()) {

Original file line number	Diff line number	Diff line change
`@@ -431,9 +431,8 @@ auto Context::LookupNameInExactScope(SemIRLoc loc, SemIR::NameId name_id,`
`431`	`431`	`auto lookup_result = scope.GetEntry(*entry_id).result;`
`432`	`432`	`if (!lookup_result.is_poisoned()) {`
`433`	`433`	`LoadImportRef(*this, lookup_result.target_inst_id());`
`434`		`- return lookup_result;`
`435`	`434`	`}`
`436`		`- return SemIR::ScopeLookupResult::MakePoisoned();`
	`435`	`+ return lookup_result;`
`437`	`436`	`}`
`438`	`437`
`439`	`438`	`if (!scope.import_ir_scopes().empty()) {`