review

Author: danakj

toolchain/check/testdata/facet/access.carbon

@@ -100,6 +100,19 @@ fn F(U:! I where .I1 = .Self) {
   (U as type) as (I where .I1 = U);
 }
 
+// --- convert_to_period_self.carbon
+library "[[@TEST_NAME]]";
+
+interface I {
+  let I1:! type;
+  let I2:! type;
+}
+
+fn F(U:! I where .I1 = .Self and .I2 = ()) {
+  U as (I where .I1 = .Self);
+  (U as type) as (I where .I1 = .Self);
+}
+
 // --- access_through_call_once.carbon
 library "[[@TEST_NAME]]";
 

toolchain/check/testdata/generic/template/fail_todo_template_access_assoc_const.carbon

@@ -12,7 +12,8 @@
 
 library "[[@TEST_NAME]]";
 
-// TODO: Improved error: no member named `I1` in `T` of type `type`.
+// TODO: This should check. The `T.I1` access should be deferred until we know
+// the value of the `template T`.
 //
 // CHECK:STDERR: fail_todo_template_access_assoc_const.carbon:[[@LINE+4]]:36: error: cannot evaluate type expression [TypeExprEvaluationFailure]
 // CHECK:STDERR: interface I(template T:! type, N:! T.I1) {