Skip to content

Commit 6b368f8

Browse files
committed
add-comment
1 parent b1fe3b0 commit 6b368f8

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

toolchain/check/testdata/impl/import_generic.carbon

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -920,9 +920,9 @@ impl forall [T:! type] D as N(T*) {}
920920
// CHECK:STDOUT: %Self.binding.as_type: type = symbolic_binding_type Self, 1, %Self.aa1546.1 [symbolic]
921921
// CHECK:STDOUT: %ptr.3f2: type = ptr_type %ptr.4f0 [symbolic]
922922
// CHECK:STDOUT: %N.type.b8d23b.2: type = facet_type <@N, @N(%ptr.3f2)> [symbolic]
923+
// CHECK:STDOUT: %Self.aa1546.2: %N.type.b8d23b.2 = symbolic_binding Self, 1 [symbolic]
923924
// CHECK:STDOUT: %I.type.71a: type = facet_type <@I, @I(%ptr.3f2)> [symbolic]
924925
// CHECK:STDOUT: %require_complete.08c: <witness> = require_complete_type %I.type.71a [symbolic]
925-
// CHECK:STDOUT: %Self.aa1546.2: %N.type.b8d23b.2 = symbolic_binding Self, 1 [symbolic]
926926
// CHECK:STDOUT: %require_complete.a37: <witness> = require_complete_type %N.type.b8d23b.2 [symbolic]
927927
// CHECK:STDOUT: %I.impl_witness.524: <witness> = impl_witness file.%I.impl_witness_table.loc6, @C.as.I.impl.3f8(%T) [symbolic]
928928
// CHECK:STDOUT: }
@@ -1372,8 +1372,8 @@ impl forall [T:! type] D as N(T*) {}
13721372
// CHECK:STDOUT: %require_complete.a37d6c.1: <witness> = require_complete_type %N.type.b8d23b.1 [symbolic]
13731373
// CHECK:STDOUT: %J.impl_witness.b5245e.1: <witness> = impl_witness file.%J.impl_witness_table.loc29, @D.as.J.impl.3b0484.1(%T) [symbolic]
13741374
// CHECK:STDOUT: %N.type.b8d23b.2: type = facet_type <@N, @N(%ptr)> [symbolic]
1375-
// CHECK:STDOUT: %require_complete.d4d: <witness> = require_complete_type %J.type.4fa [symbolic]
13761375
// CHECK:STDOUT: %Self.aa1546.2: %N.type.b8d23b.2 = symbolic_binding Self, 1 [symbolic]
1376+
// CHECK:STDOUT: %require_complete.d4d: <witness> = require_complete_type %J.type.4fa [symbolic]
13771377
// CHECK:STDOUT: %require_complete.a37d6c.2: <witness> = require_complete_type %N.type.b8d23b.2 [symbolic]
13781378
// CHECK:STDOUT: %J.impl_witness.b5245e.2: <witness> = impl_witness file.%J.impl_witness_table.loc39, @D.as.J.impl.3b0484.2(%T) [symbolic]
13791379
// CHECK:STDOUT: }

toolchain/check/type_completion.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,9 @@ static auto RequireCompleteFacetType(Context& context, SemIR::LocId loc_id,
201201
specifics_done += requires_specifics.size();
202202
}
203203

204+
// Specific definitions are resolved from the interfaces in the facet type
205+
// down, each require target depends on the specific referring to it being
206+
// resolved already.
204207
for (auto [specific_id, _] : specifics) {
205208
ResolveSpecificDefinition(context, loc_id, specific_id);
206209
}

0 commit comments

Comments
 (0)