Skip to content

Commit abd6719

Browse files
jonmeowgeoffromer
andauthored
Update toolchain/docs/diagnostics.md
Co-authored-by: Geoff Romer <[email protected]>
1 parent 068004d commit abd6719

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

toolchain/docs/diagnostics.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,8 @@ methods for formatting arguments:
171171
- `llvm::StringRef` is disallowed due to lifetime issues.
172172
- `llvm::StringLiteral` is disallowed because format providers such as
173173
`BoolAsSelect` should work in cases where a `StringLiteral` could be
174-
used.
174+
used, and because string literal parameters tend to make
175+
the resulting diagnostics hard to translate.
175176
- `llvm::format_provider<...>` specializations.
176177
- `BoolAsSelect` and `IntAsSelect` from
177178
[format_providers.h](/toolchain/diagnostics/format_providers.h) are

0 commit comments

Comments
 (0)