Fix new_proposal.py to include "Abstract" section (#2139)

josh11b · web-flow · commit e489b14de067 · 2022-09-01T14:21:04.000-07:00
"Proposal" was hard-coded as the first section and so it was deleting the "Abstract" section along with the "TODO" section.
diff --git a/proposals/scripts/new_proposal.py b/proposals/scripts/new_proposal.py
@@ -98,7 +98,7 @@ def _fill_template(template_path: str, title: str, pr_num: int) -> str:
         r"\g<1>%d" % pr_num,
         content,
     )
-    content = re.sub(r"## TODO(?:.|\n)*(## Problem)", r"\1", content)
+    content = re.sub(r"\n## TODO(?:|\n)*?(\n## )", r"\1", content)
     return content
 
 
diff --git a/proposals/scripts/new_proposal_test.py b/proposals/scripts/new_proposal_test.py
@@ -50,6 +50,7 @@ def test_fill_template(self):
             "pull/123)" in content,
             content,
         )
+        self.assertTrue("\n## Abstract\n\n" in content, content)
 
     def test_run_success(self):
         new_proposal._run(["true"])

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ def _fill_template(template_path: str, title: str, pr_num: int) -> str:`
`98`	`98`	`r"\g<1>%d" % pr_num,`
`99`	`99`	`content,`
`100`	`100`	`)`
`101`		`- content = re.sub(r"## TODO(?:.\|\n)*(## Problem)", r"\1", content)`
	`101`	`+ content = re.sub(r"\n## TODO(?:\|\n)*?(\n## )", r"\1", content)`
`102`	`102`	`return content`
`103`	`103`
`104`	`104`
Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,7 @@ def test_fill_template(self):`
`50`	`50`	`"pull/123)" in content,`
`51`	`51`	`content,`
`52`	`52`	`)`
	`53`	`+ self.assertTrue("\n## Abstract\n\n" in content, content)`
`53`	`54`
`54`	`55`	`def test_run_success(self):`
`55`	`56`	`new_proposal._run(["true"])`