compounds

Author: danakj

toolchain/check/testdata/facet/access.carbon

@@ -150,7 +150,7 @@ fn F(U:! I where .X = .Self) {
   F3(U.G().G().G());
 }
 
-// --- fail_todo_compound_access_through_call.carbon
+// --- fail_compound_access_through_call.carbon
 library "[[@TEST_NAME]]";
 
 interface I {
@@ -159,19 +159,18 @@ interface I {
 }
 
 fn F(U:! I where .X = .Self) {
-  // TODO: The return of `I.G()` is a value with type `U` which is constrained
-  // by `I`. We have access to the methods of `I` through name lookup, but how
-  // do we get to them with compound member access?
+  // It's not possible to do compound member lookup here. You'd need
+  // to work with `U.(I.X)` instead.
   // See: https://github.com/carbon-language/carbon-lang/issues/6025
   //
-  // CHECK:STDERR: fail_todo_compound_access_through_call.carbon:[[@LINE+7]]:3: error: cannot implicitly convert non-type value of type `.Self` into type implementing `I` [ConversionFailureNonTypeToFacet]
-  // CHECK:STDERR:   U.(I.G)().(I.G)().(I.G)();
+  // CHECK:STDERR: fail_compound_access_through_call.carbon:[[@LINE+7]]:3: error: cannot implicitly convert non-type value of type `.Self` into type implementing `I` [ConversionFailureNonTypeToFacet]
+  // CHECK:STDERR:   U.(I.G)().(I.G)();
   // CHECK:STDERR:   ^~~~~~~~~~~~~~~
-  // CHECK:STDERR: fail_todo_compound_access_through_call.carbon:[[@LINE+4]]:3: note: type `.Self` does not implement interface `Core.ImplicitAs(I)` [MissingImplInMemberAccessNote]
-  // CHECK:STDERR:   U.(I.G)().(I.G)().(I.G)();
+  // CHECK:STDERR: fail_compound_access_through_call.carbon:[[@LINE+4]]:3: note: type `.Self` does not implement interface `Core.ImplicitAs(I)` [MissingImplInMemberAccessNote]
+  // CHECK:STDERR:   U.(I.G)().(I.G)();
   // CHECK:STDERR:   ^~~~~~~~~~~~~~~
   // CHECK:STDERR:
-  U.(I.G)().(I.G)().(I.G)();
+  U.(I.G)().(I.G)();
 }
 
 // --- fail_non_const_associated.carbon

toolchain/check/testdata/facet/period_self.carbon

@@ -161,7 +161,7 @@ fn F(U:! I(.Self) & J(.Self)) {
   F2(U.I1().J1().I1().J1().I1().J1());
 }
 
-// --- fail_todo_return_of_period_self_impls_interface.carbon
+// --- fail_return_of_period_self_impls_interface.carbon
 library "[[@TEST_NAME]]";
 
 interface I(T:! type) {
@@ -173,23 +173,15 @@ interface J(T:! type) {
 }
 
 fn G(U:! I(.Self) where .Self impls J(.Self)) {
-  // TODO: U.I1() returns a value of type `U`. How do we call `J.J1` on that? It
-  // is accessible through non-compound member lookup when `U` extends `J`.
+  // It's not possible to do compound lookup here. You would have to work with
+  // the original type `U` instead.
   // See: https://github.com/carbon-language/carbon-lang/issues/6025
   //
-  // CHECK:STDERR: fail_todo_return_of_period_self_impls_interface.carbon:[[@LINE+12]]:11: error: type `<type of J>` does not support qualified expressions [QualifiedExprUnsupported]
-  // CHECK:STDERR:   U.I1().(J.J1)().I1().(J.J1)().I1().(J.J1)();
+  // CHECK:STDERR: fail_return_of_period_self_impls_interface.carbon:[[@LINE+4]]:11: error: type `<type of J>` does not support qualified expressions [QualifiedExprUnsupported]
+  // CHECK:STDERR:   U.I1().(J.J1)();
   // CHECK:STDERR:           ^~~~
   // CHECK:STDERR:
-  // CHECK:STDERR: fail_todo_return_of_period_self_impls_interface.carbon:[[@LINE+8]]:25: error: type `<type of J>` does not support qualified expressions [QualifiedExprUnsupported]
-  // CHECK:STDERR:   U.I1().(J.J1)().I1().(J.J1)().I1().(J.J1)();
-  // CHECK:STDERR:                         ^~~~
-  // CHECK:STDERR:
-  // CHECK:STDERR: fail_todo_return_of_period_self_impls_interface.carbon:[[@LINE+4]]:39: error: type `<type of J>` does not support qualified expressions [QualifiedExprUnsupported]
-  // CHECK:STDERR:   U.I1().(J.J1)().I1().(J.J1)().I1().(J.J1)();
-  // CHECK:STDERR:                                       ^~~~
-  // CHECK:STDERR:
-  U.I1().(J.J1)().I1().(J.J1)().I1().(J.J1)();
+  U.I1().(J.J1)();
 }
 
 // --- fail_todo_return_of_type_period_self_has_type_u.carbon