Rewrite pending specifics to use the work stack #6415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmeow
force-pushed
the
import-pending
branch
from
8a7cced to
857215b
Compare
chandlerc
approved these changes
Nov 21, 2025
Contributor
chandlerc
left a comment
chandlerc
left a comment
There was a problem hiding this comment.
Nice! The rationale makes lots of sense to me, suggested maybe even capturing some of that in code comments so its more visible.
|
|
||
| auto ImportRefResolver::PushSpecific(SemIR::SpecificId import_id, | ||
| SemIR::SpecificId local_id) -> void { | ||
| // Insert before the current instruction. |
Contributor
There was a problem hiding this comment.
Maybe add to this comment some of the nuance from the commit message around inserting into the middle of the work stack and why it should be fine?
Mostly thinking it could be helpful if this function shows up in a profile at some point because something weird changed, or if someone worries about the insert here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to figure out the right way to get specifics to be added to the work.
Technically, we could keep the pending_specific list; this is taking a different approach of inserting inside the work stack, which will do extra work moving entries, although typically that should be expected to be small. One challenge of
pending_specificsis that if we would need to shift them to work after bothDone(for immediate processing) andRetry(for processing after the current instruction is later revisited and done). That feels kind of awkward as additional tracking to do. Also, the common case is probably that there's either 0 or 1 specifics being added, so an additional vector may be significant overhead. That's why I leaned more in this direction of just inserting them in the vector of work.