[cli] refactor: factor out testRunDuration function

Author: paolino

cli/src/User/Agent/Lib.hs

@@ -1,17 +1,18 @@
 module User.Agent.Lib
     ( resolveTestRunId
     , withState
+    , testRunDuration
     ) where
 
 import Control.Applicative (Alternative (..))
 import Core.Context (WithContext, withMPFS)
-import Core.Types.Basic (TokenId)
+import Core.Types.Basic (Duration, TokenId)
 import Core.Types.Fact (Fact (..), keyHash, parseFacts)
 import Data.Foldable (find)
 import MPFS.API (MPFS (..))
 import Text.JSON.Canonical (FromJSON (..), JSValue)
 import User.Agent.Types (TestRunId (..))
-import User.Types (Phase (..), TestRun, TestRunState)
+import User.Types (Phase (..), TestRun, TestRunState (..))
 
 resolveTestRunId
     :: forall s m
@@ -42,3 +43,9 @@ withState f v =
     state
         :: forall s. FromJSON Maybe (TestRunState s) => Maybe (TestRunState s)
     state = fromJSON v
+
+testRunDuration :: TestRunState v -> Duration
+testRunDuration (Pending d _) = d
+testRunDuration (Rejected pending _) = testRunDuration pending
+testRunDuration (Accepted pending) = testRunDuration pending
+testRunDuration (Finished accepted _ _) = testRunDuration accepted

cli/src/User/Agent/PushTest.hs

@@ -52,11 +52,11 @@ import Text.JSON.Canonical
     , ToJSON (..)
     , renderCanonicalJSON
     )
-import User.Agent.Lib (resolveTestRunId, withState)
+import User.Agent.Lib (resolveTestRunId, testRunDuration, withState)
 import User.Agent.Types
     ( TestRunId (..)
     )
-import User.Types (TestRun (..), TestRunState (..))
+import User.Types (TestRun (..))
 
 dockerfile :: String
 dockerfile =
@@ -195,12 +195,6 @@ collectImagesFromAssets (Directory dirname) = do
     let images = nub . sort . filter (not . null) . lines
     return $ output <&> images
 
-pickDuration :: TestRunState v -> Duration
-pickDuration (Pending d _) = d
-pickDuration (Rejected pending _) = pickDuration pending
-pickDuration (Accepted pending) = pickDuration pending
-pickDuration (Finished accepted _ _) = pickDuration accepted
-
 getTestRun
     :: Monad m
     => TokenId
@@ -213,7 +207,7 @@ getTestRun tk testRunId = do
     mts <- lift $ resolveTestRunId tk testRunId
     Fact tr v <- liftMaybe (Couldn'tResolveTestRunId testRunId) mts
     liftMaybe (Couldn'tResolveTestRunId testRunId)
-        $ withState (\state -> (tr, pickDuration state)) v
+        $ withState (\state -> (tr, testRunDuration state)) v
 
 data AntithesisAuth = AntithesisAuth
     { username :: String