Merge pull request #256 from cardano-foundation/fix/ID-203-Unintended-Voucher-Minting

Fix: Prevent unintended voucher(s) from being minted

Author: nemo83

cardano/onchain/validators/minting_voucher.test.ak

@@ -15,7 +15,6 @@ use ibc/apps/transfer/types/coin as transfer_coin
 use ibc/apps/transfer/types/fungible_token_packet_data.{FungibleTokenPacketData}
 use ibc/auth.{AuthToken}
 use ibc/core/ics_004/types/acknowledgement
-use ibc/core/ics_004/types/acknowledgement_response.{AcknowledgementResult}
 use ibc/core/ics_005/types/ibc_module_redeemer.{
   Callback, OnAcknowledgementPacket, OnRecvPacket, OnTimeoutPacket, Operator,
   TransferModuleData, TransferModuleOperator,

cardano/onchain/validators/spending_transfer_module.ak

@@ -264,6 +264,10 @@ fn handler_callback(
         packet.source_channel,
         data.denom,
       ) {
+        // check no minting voucher here
+        expect None =
+          pairs.get_first(redeemers, Mint(voucher_minting_policy_id))
+
         let voucher_prefix_len =
           transfer_coin.get_denom_prefix(
             packet.source_port,
@@ -794,6 +798,9 @@ fn validate_refund_packet_token(
     packet.source_channel,
     data.denom,
   ) {
+    // check no minting voucher here
+    expect None = pairs.get_first(redeemers, Mint(voucher_minting_policy_id))
+
     expect Some(escrowed_token_unit) =
       string_utils.hex_string_to_bytes(data.denom)
     trace @"spend_transfer_module: demon convert to token unit valid"

cardano/onchain/validators/spending_transfer_module.test.ak

@@ -712,6 +712,117 @@ test on_recv_packet_unescrow_succeed() {
   )
 }
 
+test on_recv_packet_unescrow_fail_unwanted_voucher() fail {
+  let mock = setup()
+
+  let transfer_amount = 1234
+
+  let receiver = mock.cardano_public_key_hash
+
+  //==========================arrange inputs=========================
+  let inputs = [mock.module_input, mock.channel_input]
+
+  //==========================arrange outputs=========================
+  let module_output =
+    Output {
+      ..mock.module_output,
+      value: mock.module_output.value
+        |> add(ada_policy_id, ada_asset_name, -transfer_amount),
+    }
+
+  expect Some(receiver_public_key_hash) =
+    string_utils.hex_string_to_bytes(receiver)
+
+  let receiver_output =
+    Output {
+      address: from_verification_key(receiver_public_key_hash),
+      value: from_asset(ada_policy_id, ada_asset_name, transfer_amount),
+      datum: NoDatum,
+      reference_script: None,
+    }
+
+  let outputs = [module_output, mock.channel_output, receiver_output]
+
+  //==========================arrange redeemers=========================
+  let acknowledgement = acknowledgement_mod.new_result_acknowledgement("AQ==")
+
+  let source_port = "port-0"
+  let source_channel = "channel-0"
+
+  let denom =
+    transfer_coin.get_denom_prefix(source_port, source_channel)
+      |> bytearray.concat("6c6f76656c616365")
+
+  let (ftpd, packet) =
+    build_packet(
+      denom,
+      transfer_amount,
+      mock.cosmos_address,
+      receiver,
+      source_port,
+      source_channel,
+      mock.port_id,
+      mock.channel_id,
+    )
+
+  let packet_data = TransferModuleData(ftpd)
+
+  let module_redeemer: Redeemer =
+    Callback(
+      OnRecvPacket {
+        channel_id: mock.channel_id,
+        acknowledgement,
+        data: packet_data,
+      },
+    )
+
+  let channel_redeemer: Redeemer =
+    RecvPacket {
+      packet,
+      proof_commitment: mock.proof,
+      proof_height: mock.proof_height,
+    }
+
+  let mint_voucher_redeemer: Redeemer =
+    MintVoucher {
+      packet_source_port: packet.source_port,
+      packet_source_channel: packet.source_channel,
+      packet_dest_port: packet.destination_port,
+      packet_dest_channel: packet.destination_channel,
+    }
+
+  let redeemers: Pairs<ScriptPurpose, Redeemer> =
+    [
+      Pair(Spend(mock.module_input.output_reference), module_redeemer),
+      Pair(Spend(mock.channel_input.output_reference), channel_redeemer),
+      Pair(Mint(mock.voucher_minting_policy_id), mint_voucher_redeemer),
+    ]
+
+  //==========================arrange context=========================
+  let transaction =
+    Transaction {
+      ..transaction.placeholder,
+      inputs: inputs,
+      outputs: outputs,
+      redeemers: redeemers,
+    }
+
+  expect module_redeemer: IBCModuleRedeemer = module_redeemer
+
+  spending_transfer_module.spend_transfer_module.spend(
+    mock.handler_token,
+    mock.port_token,
+    mock.module_token,
+    mock.port_id,
+    mock.channel_minting_policy_id,
+    mock.voucher_minting_policy_id,
+    None,
+    module_redeemer,
+    mock.module_input.output_reference,
+    transaction,
+  )
+}
+
 test transfer_escrow_succeed() {
   let mock = setup()