feat: removing overhead and unused methods. clean up and refactoring

Author: fabianbormann

calculation/src/main/java/org/cardanofoundation/rewards/calculation/EpochCalculation.java

@@ -12,17 +12,15 @@
 
 import static org.cardanofoundation.rewards.calculation.PoolRewardsCalculation.calculatePoolRewardInEpoch;
 import static org.cardanofoundation.rewards.calculation.constants.RewardConstants.*;
-import static org.cardanofoundation.rewards.calculation.constants.RewardConstants.MAINNET_BOOTSTRAP_ADDRESS_AMOUNT;
 import static org.cardanofoundation.rewards.calculation.util.BigNumberUtils.*;
-import static org.cardanofoundation.rewards.calculation.util.CurrencyConverter.lovelaceToAda;
 import lombok.extern.slf4j.Slf4j;
 
 @Slf4j
 public class EpochCalculation {
 
     public static EpochCalculationResult calculateEpochRewardPots(final int epoch, final AdaPots adaPotsForPreviousEpoch,
                                                                   final ProtocolParameters protocolParameters, final Epoch epochInfo,
-                                                                  final List<PoolDeregistration> retiredPools,
+                                                                  final HashSet<String> rewardAddressesOfRetiredPools,
                                                                   final HashSet<String> deregisteredAccounts,
                                                                   final List<MirCertificate> mirCertificates,
                                                                   final List<String> poolsThatProducedBlocksInEpoch,
@@ -83,8 +81,7 @@ public static EpochCalculationResult calculateEpochRewardPots(final int epoch, f
 
         // The sum of all the refunds attached to unregistered reward accounts are added to the
         // treasury (see: Pool Reap Transition, p.53, figure 40, shelley-ledger.pdf)
-        if (retiredPools.size() > 0) {
-            List<String> rewardAddressesOfRetiredPools = retiredPools.stream().map(PoolDeregistration::getRewardAddress).toList();
+        if (rewardAddressesOfRetiredPools.size() > 0) {
             List<String> deregisteredOwnerAccounts = deregisteredAccountsOnEpochBoundary.stream()
                     .filter(rewardAddressesOfRetiredPools::contains).toList();
             List<String> ownerAccountsRegisteredInThePast = registeredAccountsUntilNow.stream()
@@ -93,8 +90,7 @@ public static EpochCalculationResult calculateEpochRewardPots(final int epoch, f
             /* Check if the reward address of the retired pool has been unregistered before
                or if the reward address has been unregistered after the randomness stabilization window
                or if the reward address has not been registered at all */
-            for (PoolDeregistration retiredPool : retiredPools) {
-                String rewardAddress = retiredPool.getRewardAddress();
+            for (String rewardAddress : rewardAddressesOfRetiredPools) {
                 if (deregisteredOwnerAccounts.contains(rewardAddress) ||
                         !ownerAccountsRegisteredInThePast.contains(rewardAddress)) {
                     // If the reward address has been unregistered, the deposit can not be returned
@@ -181,7 +177,7 @@ public static EpochCalculationResult calculateEpochRewardPots(final int epoch, f
             calculatedReserve = calculatedReserve.add(MAINNET_BOOTSTRAP_ADDRESS_AMOUNT);
         }
 
-        log.debug("Unspendable earned rewards: " + lovelaceToAda(unspendableEarnedRewards.longValue()) + " ADA");
+        log.debug("Unspendable earned rewards: " + unspendableEarnedRewards.longValue() + " Lovelace");
         treasuryForCurrentEpoch = add(treasuryForCurrentEpoch, unspendableEarnedRewards);
 
         TreasuryCalculationResult treasuryCalculationResult = TreasuryCalculationResult.builder()

calculation/src/main/java/org/cardanofoundation/rewards/calculation/PoolRewardsCalculation.java

@@ -129,7 +129,7 @@ public static BigInteger calculateMemberReward(BigInteger poolReward, double mar
     public static PoolRewardCalculationResult calculatePoolRewardInEpoch(final String poolId, final PoolHistory poolHistoryCurrentEpoch,
                                                                          final int totalBlocksInEpoch, final ProtocolParameters protocolParameters,
                                                                          final BigInteger adaInCirculation, final BigInteger activeStakeInEpoch, BigInteger stakePoolRewardsPot,
-                                                                         final BigInteger totalActiveStakeOfOwners, final List<String> poolOwnerStakeAddresses,
+                                                                         final BigInteger totalActiveStakeOfOwners, final HashSet<String> poolOwnerStakeAddresses,
                                                                          final HashSet<String> deregisteredAccounts, final boolean ignoreLeaderReward,
                                                                          final HashSet<String> lateDeregisteredAccounts,
                                                                          final HashSet<String> accountsRegisteredInThePast) {

calculation/src/main/java/org/cardanofoundation/rewards/calculation/TreasuryCalculation.java

@@ -17,7 +17,7 @@ public class TreasuryCalculation {
 
   public static TreasuryCalculationResult calculateTreasuryInEpoch(int epoch, ProtocolParameters protocolParameters,
                                                                    AdaPots adaPotsForPreviousEpoch, Epoch epochInfo,
-                                                                   List<PoolDeregistration> retiredPools,
+                                                                   HashSet<String> rewardAddressesOfRetiredPools,
                                                                    List<MirCertificate> mirCertificates,
                                                                    final HashSet<String> deregisteredAccounts,
                                                                    final HashSet<String> registeredAccountsUntilNow,
@@ -58,14 +58,13 @@ public static TreasuryCalculationResult calculateTreasuryInEpoch(int epoch, Prot
     final BigInteger treasuryCut = multiplyAndFloor(totalRewardPot, treasuryGrowthRate);
     BigInteger treasuryForCurrentEpoch = treasuryInPreviousEpoch.add(treasuryCut);
 
-    if (retiredPools.size() > 0) {
-      List<String> rewardAddressesOfRetiredPools = retiredPools.stream().map(PoolDeregistration::getRewardAddress).toList();
+    if (rewardAddressesOfRetiredPools.size() > 0) {
       HashSet<String> deregisteredRewardAccounts = deregisteredAccounts.stream()
               .filter(rewardAddressesOfRetiredPools::contains).collect(Collectors.toCollection(HashSet::new));
       List<String> ownerAccountsRegisteredInThePast = registeredAccountsUntilNow.stream()
               .filter(rewardAddressesOfRetiredPools::contains).toList();
 
-      BigInteger unclaimedRefunds = calculateUnclaimedRefundsForRetiredPools(retiredPools, deregisteredRewardAccounts, ownerAccountsRegisteredInThePast);
+      BigInteger unclaimedRefunds = calculateUnclaimedRefundsForRetiredPools(rewardAddressesOfRetiredPools, deregisteredRewardAccounts, ownerAccountsRegisteredInThePast);
       treasuryForCurrentEpoch = treasuryForCurrentEpoch.add(unclaimedRefunds);
     }
 
@@ -138,16 +137,15 @@ private static BigDecimal calculateEta(int totalBlocksInEpochByPools, BigDecimal
     pool's registered reward account, provided the reward account is still registered." -
     https://github.com/input-output-hk/cardano-ledger/blob/9e2f8151e3b9a0dde9faeb29a7dd2456e854427c/eras/shelley/formal-spec/epoch.tex#L546C9-L547C87
    */
-  public static BigInteger calculateUnclaimedRefundsForRetiredPools(List<PoolDeregistration> retiredPools,
+  public static BigInteger calculateUnclaimedRefundsForRetiredPools(HashSet<String> rewardAddressesOfRetiredPools,
                                                                     HashSet<String> deregisteredRewardAccounts,
                                                                     List<String> ownerAccountsRegisteredInThePast) {
     BigInteger unclaimedRefunds = BigInteger.ZERO;
-    if (retiredPools.size() > 0) {
+    if (rewardAddressesOfRetiredPools.size() > 0) {
     /* Check if the reward address of the retired pool has been unregistered before
        or if the reward address has been unregistered after the randomness stabilization window
        or if the reward address has not been registered at all */
-      for (PoolDeregistration retiredPool : retiredPools) {
-        String rewardAddress = retiredPool.getRewardAddress();
+      for (String rewardAddress : rewardAddressesOfRetiredPools) {
         if (deregisteredRewardAccounts.contains(rewardAddress) ||
                 !ownerAccountsRegisteredInThePast.contains(rewardAddress)) {
           // If the reward address has been unregistered, the deposit can not be returned

calculation/src/main/java/org/cardanofoundation/rewards/calculation/domain/AccountUpdate.java

@@ -12,13 +12,8 @@
 @AllArgsConstructor
 public class Epoch {
     private int number;
-    private BigInteger output;
     private BigInteger fees;
     private int blockCount;
     private BigInteger activeStake;
-    private List<String> poolsMadeBlocks;
     private int nonOBFTBlockCount;
-    private int OBFTBlockCount;
-    private long unixTimeFirstBlock;
-    private long unixTimeLastBlock;
 }

calculation/src/main/java/org/cardanofoundation/rewards/calculation/domain/Epoch.java

@@ -11,8 +11,6 @@
 @NoArgsConstructor
 @AllArgsConstructor
 public class MirCertificate {
-    private long blockTime;
     private MirPot pot;
-    private int totalStakeKeys;
     private BigInteger totalRewards;
 }

calculation/src/main/java/org/cardanofoundation/rewards/calculation/domain/MirCertificate.java

@@ -14,9 +14,8 @@
 public class PoolHistory {
     private String poolId;
     private BigInteger activeStake;
-    private BigInteger delegatorRewards;
     private String rewardAddress;
-    private List<String> owners;
+    private HashSet<String> owners;
     private BigInteger ownerActiveStake;
     private BigInteger poolFees;
     private Double margin;