Enforce -Wmissing-local-signatures (#2130)

Resolves #1748

Author: vrom911

hydra-cardano-api/hydra-cardano-api.cabal

@@ -33,7 +33,7 @@ common project-config
   ghc-options:
     -Wall -Wcompat -Widentities -Wincomplete-record-updates
     -Wincomplete-uni-patterns -Wredundant-constraints -Wunused-packages
-    -Wmissing-deriving-strategies -fprint-potential-instances
+    -fprint-potential-instances -Wmissing-local-signatures
 
 library
   import:          project-config

hydra-cardano-api/src/Hydra/Cardano/Api/AddressInEra.hs

@@ -87,6 +87,7 @@ fromPlutusAddress network plutusAddress =
       (cred, Nothing) ->
         Ledger.Addr network (unsafeCredential cred) Ledger.StakeRefNull
  where
+  unsafeCredential :: Plutus.Credential -> Ledger.Credential keyRole
   unsafeCredential = \case
     PubKeyCredential (Plutus.PubKeyHash h) ->
       Ledger.KeyHashObj . Ledger.KeyHash . unsafeHashFromBytes $ fromBuiltin h

hydra-cardano-api/src/Hydra/Cardano/Api/BlockHeader.hs

@@ -28,6 +28,7 @@ genBlockHeaderHash :: Gen (Hash BlockHeader)
 genBlockHeaderHash =
   unsafeBlockHeaderHashFromBytes . BS.pack <$> vectorOf 32 arbitrary
  where
+  unsafeBlockHeaderHashFromBytes :: ByteString -> Hash BlockHeader
   unsafeBlockHeaderHashFromBytes bytes =
     case deserialiseFromRawBytes (proxyToAsType Proxy) bytes of
       Left e ->

hydra-cardano-api/src/Hydra/Cardano/Api/Pretty.hs

@@ -9,6 +9,7 @@ import Cardano.Binary (serialize)
 import Cardano.Ledger.Alonzo.Scripts qualified as Ledger
 import Cardano.Ledger.Alonzo.TxWits qualified as Ledger
 import Cardano.Ledger.Core qualified as Ledger
+import Cardano.Ledger.Plutus.Data qualified as Ledger
 import Data.Aeson qualified as Aeson
 import Data.ByteString.Lazy qualified as BL
 import Data.Function (on)
@@ -137,6 +138,7 @@ renderTxWithUTxO utxo (Tx body _wits) =
    where
     indent = "\n  " <> T.replicate n "    "
 
+  prettyDatumUtxo :: Api.TxOutDatum ctx -> String
   prettyDatumUtxo = \case
     TxOutDatumNone ->
       "TxOutDatumNone"
@@ -170,6 +172,7 @@ renderTxWithUTxO utxo (Tx body _wits) =
 
   totalScriptSize = sum $ BL.length . serialize <$> scripts
 
+  prettyScript :: Ledger.Script LedgerEra -> String
   prettyScript script =
     "Script (" <> show (Ledger.hashScript script) <> ")"
 
@@ -179,6 +182,7 @@ renderTxWithUTxO utxo (Tx body _wits) =
       "== DATUMS (" <> show (length dats) <> ")"
         : (("- " <>) . showDatumAndHash <$> Map.toList dats)
 
+  showDatumAndHash :: (Ledger.SafeHash i, Ledger.Data era) -> String
   showDatumAndHash (k, v) =
     mconcat
       [ show (Ledger.extractHash k)
@@ -196,6 +200,7 @@ renderTxWithUTxO utxo (Tx body _wits) =
        in "== REDEEMERS (" <> show (length rdmrs) <> ")"
             : (("- " <>) . prettyRedeemer <$> rdmrs)
 
+  prettyRedeemer :: forall p era. Show p => (p, (Ledger.Data era, Ledger.ExUnits)) -> String
   prettyRedeemer (purpose, (redeemerData, redeemerBudget)) =
     unwords
       [ show purpose

hydra-cardano-api/src/Hydra/Cardano/Api/TxOut.hs

@@ -187,6 +187,7 @@ toPlutusTxOut =
   -- a 'Left', which we expect to throw away anyway on 'eitherToMaybe'.
   eitherToMaybe . Ledger.transTxOutV2 (error "TxOutSource used unexpectedly") . toLedgerTxOut
  where
+  eitherToMaybe :: Either a b -> Maybe b
   eitherToMaybe = \case
     Left _ -> Nothing
     Right x -> Just x

hydra-cardano-api/src/Hydra/Cardano/Api/Value.hs

@@ -19,6 +19,7 @@ containsValue :: Value -> Value -> Bool
 containsValue a b =
   all positive . toList $ a <> negateValue b
  where
+  positive :: (a, Quantity) -> Bool
   positive (_, q) = q >= 0
 
 -- | Calculate minimum ada as 'Value' for a 'TxOut'.
@@ -81,6 +82,7 @@ fromPlutusValue :: Plutus.Value -> Maybe Value
 fromPlutusValue plutusValue = do
   fmap fromList . mapM convertAsset $ flattenValue plutusValue
  where
+  convertAsset :: (Plutus.CurrencySymbol, Plutus.TokenName, Integer) -> Maybe (AssetId, Quantity)
   convertAsset (cs, tk, i)
     | cs == adaSymbol && tk == adaToken =
         pure (AdaAssetId, Quantity i)

hydra-chain-observer/hydra-chain-observer.cabal

@@ -34,7 +34,7 @@ common project-config
   ghc-options:
     -Wall -Wcompat -Widentities -Wincomplete-record-updates
     -Wincomplete-uni-patterns -Wredundant-constraints -Wunused-packages
-    -fprint-potential-instances
+    -fprint-potential-instances -Wmissing-local-signatures
 
 library
   import:          project-config

hydra-chain-observer/src/Hydra/Blockfrost/ChainObserver.hs

@@ -14,7 +14,7 @@ import Control.Concurrent.Class.MonadSTM (
   newTVarIO,
   writeTVar,
  )
-import Control.Retry (constantDelay, retrying)
+import Control.Retry (RetryPolicyM, RetryStatus, constantDelay, retrying)
 import Data.ByteString.Base16 qualified as Base16
 import Hydra.Cardano.Api (
   ChainPoint (..),
@@ -104,10 +104,12 @@ blockfrostClient tracer projectPath blockConfirmations = do
                   pure $ Left ex
       }
  where
+  shouldRetry :: MonadIO m => RetryStatus -> Either APIBlockfrostError b -> m Bool
   shouldRetry _ = \case
     Right{} -> pure False
     Left err -> pure $ isRetryable err
 
+  retryPolicy :: DiffTime -> RetryPolicyM IO
   retryPolicy blockTime = constantDelay (truncate blockTime * 1000 * 1000)
 
 -- | Iterative process that follows the chain using a naive roll-forward approach,

hydra-chain-observer/src/Hydra/ChainObserver/Options.hs

@@ -94,6 +94,7 @@ hydraChainObserverOptions =
         <> header "hydra-chain-observer"
     )
  where
+  versionInfo :: Parser (a -> a)
   versionInfo =
     infoOption
       (showVersion hydraNodeVersion)

hydra-cluster/bench/Bench/EndToEnd.hs

@@ -22,6 +22,7 @@ import Control.Lens (to, (^..), (^?))
 import Control.Monad.Class.MonadAsync (mapConcurrently)
 import Data.Aeson (Result (Error, Success), Value, encode, fromJSON, (.=))
 import Data.Aeson.Lens (key, values, _JSON, _Number, _String)
+import Data.ByteString.Lazy qualified as LBS
 import Data.List qualified as List
 import Data.Map qualified as Map
 import Data.Scientific (Scientific)
@@ -130,6 +131,12 @@ benchDemo networkId nodeSocket timeoutSeconds hydraClients workDir dataset@Datas
                 (leader : followers) ->
                   (,[]) <$> scenario hydraTracer backend workDir dataset (leader :| followers)
  where
+  withHydraClientConnections ::
+    Tracer IO HydraNodeLog ->
+    [(Host, Int)] ->
+    [HydraClient] ->
+    ([HydraClient] -> IO a) ->
+    IO a
   withHydraClientConnections tracer apiHosts connections action = do
     case apiHosts of
       [] -> action connections
@@ -309,10 +316,14 @@ movingAverage confirmations =
       timeSlice t@UTCTime{utctDayTime} =
         t{utctDayTime = fromIntegral (floor (utctDayTime / window) * window :: Integer)}
 
+      fiveSecSlice :: (UTCTime, NominalDiffTime, NominalDiffTime) -> (UTCTime, NominalDiffTime, NominalDiffTime) -> Bool
       fiveSecSlice (timeSlice -> t1, _, _) (timeSlice -> t2, _, _) = t1 == t2
 
+      fst3 :: (a, b, c) -> a
       fst3 (a, _, _) = a
+      snd3 :: (a, b, c) -> b
       snd3 (_, a, _) = a
+      thd3 :: (a, b, c) -> c
       thd3 (_, _, a) = a
 
       average = \case
@@ -481,21 +492,29 @@ waitForAllConfirmations n1 Registry{processedTxs} allIds = do
   waitForSnapshotConfirmation = waitMatch 20 n1 $ \v ->
     maybeTxValid v <|> maybeTxInvalid v <|> maybeSnapshotConfirmed v
 
+  maybeTxValid :: Value -> Maybe WaitResult
   maybeTxValid v = do
     guard (v ^? key "tag" == Just "TxValid")
     v
-      ^? key "transactionId" . to fromJSON >>= \case
-        Error _ -> Nothing
-        Success txid -> pure $ TxValid txid
+      ^? key "transactionId"
+        . to fromJSON
+        >>= \case
+          Error _ -> Nothing
+          Success txid -> pure $ TxValid txid
 
+  maybeTxInvalid :: Value -> Maybe WaitResult
   maybeTxInvalid v = do
     guard (v ^? key "tag" == Just "TxInvalid")
     v
-      ^? key "transaction" . key "txId" . to fromJSON >>= \case
-        Error _ -> Nothing
-        Success tx ->
-          TxInvalid tx <$> v ^? key "validationError" . key "reason" . _String
-
+      ^? key "transaction"
+        . key "txId"
+        . to fromJSON
+        >>= \case
+          Error _ -> Nothing
+          Success tx ->
+            TxInvalid tx <$> v ^? key "validationError" . key "reason" . _String
+
+  maybeSnapshotConfirmed :: Value -> Maybe WaitResult
   maybeSnapshotConfirmed v = do
     guard (v ^? key "tag" == Just "SnapshotConfirmed")
     snapshot <- v ^? key "snapshot"
@@ -553,4 +572,5 @@ writeResultsCsv fp res = do
  where
   headers = "txId,confirmationTime"
 
+  toCsv :: (UTCTime, NominalDiffTime, NominalDiffTime, Int) -> LBS.ByteString
   toCsv (a, b, c, d) = show a <> "," <> encode b <> "," <> encode c <> "," <> encode d <> "\n"