Remove reportingHost as it is not needed

Every peer receives cluster id mismatch so there is no single
reporting host.

Signed-off-by: Sasha Bogicevic <[email protected]>

Author: v0d1ch

docs/docs/known-issues.md

@@ -31,7 +31,6 @@ Known errors are:
    - check configuration with other participants. There should be a corresponding log entry `NetworkClusterIDMismatch` with the information on:
       - `clusterPeers` - loaded peers info received from `etcd` cluster.
       - `configuredPeers` - peers info coming from `hydra-node` arguments.
-      - `reportingHost` - host that received the error.
 
  - `member ... has already been bootstrapped` - missing information in `<persistence-dir>/etcd`
    - need to bootstrap new cluster or manual workarounds, see also https://etcd.io/docs/v3.5/op-guide/failures/

hydra-cluster/src/Hydra/Cluster/Scenarios.hs

@@ -1182,22 +1182,18 @@ startWithWrongPeers workDir tracer node@RunningNode{nodeSocket} hydraScriptsTxId
 
   let hydraTracer = contramap FromHydraNode tracer
   withHydraNode hydraTracer aliceChainConfig workDir 3 aliceSk [bobVk] [3, 4] $ \n1 -> do
-    -- NOTE: here we deliberately use the wrong peer list for Bob, which should be visible
-    -- in network message sent to Alice.
+    -- NOTE: here we deliberately use the wrong peer list for Bob
     withHydraNode hydraTracer bobChainConfig workDir 4 bobSk [aliceVk] [4] $ \_ -> do
       seedFromFaucet_ node aliceCardanoVk 100_000_000 (contramap FromFaucet tracer)
 
-      (clusterPeers, reportingHost, configuredPeers) <- waitMatch 20 n1 $ \v -> do
+      (clusterPeers, configuredPeers) <- waitMatch 20 n1 $ \v -> do
         guard $ v ^? key "tag" == Just (Aeson.String "NetworkClusterIDMismatch")
         clusterPeers <- v ^? key "clusterPeers" . _String
-        reportingHost <- v ^? key "reportingHost" . _String
         configuredPeers <- v ^? key "misconfiguredPeers" . _String
-        pure (clusterPeers, reportingHost, configuredPeers)
+        pure (clusterPeers, configuredPeers)
 
       when (clusterPeers == configuredPeers) $
         failure "Expected clusterPeers and configuredPeers to be different"
-      -- NOTE: reporting host is the host receiving the error, which is Alice
-      reportingHost `shouldBe` "http://0.0.0.0:5003"
       clusterPeers `shouldBe` "0.0.0.0:5003=http://0.0.0.0:5003,0.0.0.0:5004=http://0.0.0.0:5004"
       configuredPeers `shouldBe` "0.0.0.0:5004=http://0.0.0.0:5004"
 

hydra-node/golden/ServerOutput/NetworkClusterIDMismatch.json

@@ -2,8 +2,7 @@
     "samples": [
         {
             "clusterPeers": "",
-            "misconfiguredPeers": "`",
-            "reportingHost": "",
+            "misconfiguredPeers": "",
             "tag": "NetworkClusterIDMismatch"
         }
     ],

hydra-node/golden/StateChanged/NetworkClusterIDMismatch.json

@@ -3,7 +3,6 @@
         {
             "clusterPeers": "",
             "misconfiguredPeers": "$",
-            "reportingHost": "",
             "tag": "NetworkClusterIDMismatch"
         }
     ],

hydra-node/json-schemas/api.yaml

@@ -1006,8 +1006,6 @@ components:
           enum: ["NetworkClusterIDMismatch"]
         clusterPeers:
           type: string
-        reportingHost:
-          type: string
         misconfiguredPeers:
           type: string
         seq:

hydra-node/src/Hydra/API/ServerOutput.hs

@@ -144,7 +144,6 @@ data ServerOutput tx
       }
   | NetworkClusterIDMismatch
       { clusterPeers :: Text
-      , reportingHost :: Text
       , misconfiguredPeers :: Text
       }
   | PeerConnected {peer :: Host}

hydra-node/src/Hydra/HeadLogic.hs

@@ -112,8 +112,8 @@ onConnectionEvent misconfiguredPeers = \case
     newState NetworkDisconnected
   Network.VersionMismatch{ourVersion, theirVersion} ->
     newState NetworkVersionMismatch{ourVersion, theirVersion}
-  Network.ClusterIDMismatch{clusterPeers, reportingHost} ->
-    newState NetworkClusterIDMismatch{clusterPeers, reportingHost, misconfiguredPeers}
+  Network.ClusterIDMismatch{clusterPeers} ->
+    newState NetworkClusterIDMismatch{clusterPeers, misconfiguredPeers}
   Network.PeerConnected{peer} ->
     newState PeerConnected{peer}
   Network.PeerDisconnected{peer} ->

hydra-node/src/Hydra/HeadLogic/Outcome.hs

@@ -62,7 +62,6 @@ data StateChanged tx
       }
   | NetworkClusterIDMismatch
       { clusterPeers :: Text
-      , reportingHost :: Text
       , misconfiguredPeers :: Text
       }
   | HeadInitialized

hydra-node/src/Hydra/Network.hs

@@ -187,7 +187,6 @@ data Connectivity
       }
   | ClusterIDMismatch
       { clusterPeers :: Text
-      , reportingHost :: Text
       }
   deriving stock (Generic, Eq, Show)
   deriving anyclass (ToJSON)

hydra-node/src/Hydra/Network/Etcd.hs

@@ -202,7 +202,7 @@ withEtcdNetwork tracer protocolVersion config callback action = do
                 pure (level', msg')
           case expectedClusterMismatch of
             Just (Aeson.String "error", Aeson.String "request sent was ignored due to cluster ID mismatch") ->
-              onConnectivity ClusterIDMismatch{clusterPeers = T.pack clusterPeers, reportingHost = T.pack $ httpUrl advertise}
+              onConnectivity ClusterIDMismatch{clusterPeers = T.pack clusterPeers}
             _ -> traceWith tracer $ EtcdLog{etcd = v}
 
   -- XXX: Could use TLS to secure peer connections