Connect network file parsing with argument parsing

Signed-off-by: Sasha Bogicevic <[email protected]>

Author: v0d1ch

hydra-node/src/Hydra/NetworkVersions.hs

@@ -12,46 +12,37 @@ import Data.Aeson.KeyMap qualified as KeyMap
 import Data.Aeson.Lens (members, _Object)
 import Data.FileEmbed (embedFile)
 import Data.List qualified as List
-import Data.Text (splitOn)
+import Data.Text (pack, splitOn, toLower, unpack)
 import Data.Text.Encoding (encodeUtf8)
-import Hydra.Cardano.Api (NetworkId (..), NetworkMagic (..), TxId, deserialiseFromRawBytesHex)
+import Hydra.Cardano.Api (TxId, deserialiseFromRawBytesHex)
 
 networkVersionsFile :: ByteString
 networkVersionsFile = $(embedFile "./../networks.json")
 
-data ParseError
-  = ExpectedStringForTxId
+data NetworkParseError
+  = ExpectedJSONStringForTxId
   | FailedToParseTextToTxId Text
   | UnknownNetwork Text
   deriving stock (Eq, Show)
 
-instance Exception ParseError
-
-parseNetworkVersions :: ByteString -> IO [(NetworkId, [TxId])]
-parseNetworkVersions bs = do
-  let info = bs ^@.. members . _Object
-  fmap catMaybes <$> forM info $ \(n, t) -> do
-    let textKey = Key.toText n
-    case textKey of
-      "mainnet" -> do
-        txids <- getLastTxId t
-        pure $ Just (Mainnet, txids)
-      "preview" -> do
-        txids <- getLastTxId t
-        pure $ Just (Testnet $ NetworkMagic 2, txids)
-      "preprod" -> do
-        txids <- getLastTxId t
-        pure $ Just (Testnet $ NetworkMagic 1, txids)
-      _ -> pure Nothing
+instance Exception NetworkParseError
+
+parseNetworkTxIds :: String -> Either String [TxId]
+parseNetworkTxIds networkString = do
+  let networkTxt = toLower $ pack networkString
+  let info = networkVersionsFile ^@.. members . _Object
+  case find (\(n, _) -> Key.toText n == networkTxt) info of
+    Nothing -> Left $ "Unknown network:" <> unpack networkTxt
+    Just (_, t) -> getLastTxId t
  where
   getLastTxId t = do
     lastTxIds <-
       case List.last $ KeyMap.elems t of
-        String s -> pure s
-        _ -> throwIO ExpectedStringForTxId
+        String s -> Right s
+        _ -> Left "Failed to find the last tx-id string in networks.json"
     mapM parseToTxId (splitOn "," lastTxIds)
 
   parseToTxId textTxId = do
     case deserialiseFromRawBytesHex $ encodeUtf8 textTxId of
-      Left _ -> throwIO $ FailedToParseTextToTxId textTxId
-      Right txid -> pure txid
+      Left _ -> Left $ "Failed to parse string to TxId: " <> unpack textTxId
+      Right txid -> Right txid

hydra-node/src/Hydra/Options.hs

@@ -38,6 +38,7 @@ import Hydra.Contract qualified as Contract
 import Hydra.Ledger.Cardano ()
 import Hydra.Logging (Verbosity (..))
 import Hydra.Network (Host (..), NodeId (NodeId), PortNumber, WhichEtcd (..), readHost, readPort, showHost)
+import Hydra.NetworkVersions (parseNetworkTxIds)
 import Hydra.Node.DepositPeriod (DepositPeriod (..))
 import Hydra.Tx.ContestationPeriod (ContestationPeriod, fromNominalDiffTime)
 import Hydra.Tx.HeadId (HeadSeed)
@@ -521,7 +522,7 @@ ledgerGenesisFileParser =
 cardanoChainConfigParser :: Parser CardanoChainConfig
 cardanoChainConfigParser =
   CardanoChainConfig
-    <$> (hydraScriptsTxIdsParser <|> many hydraScriptsTxIdParser)
+    <$> ((hydraScriptsTxIdsParser <|> many hydraScriptsTxIdParser) <|> hydraScriptsDefaultParser)
     <*> cardanoSigningKeyFileParser
     <*> many cardanoVerificationKeyFileParser
     <*> optional startChainFromParser
@@ -802,6 +803,22 @@ hydraScriptsTxIdParser =
           \can use the 'publish-scripts' sub-command to publish them yourself."
     )
 
+hydraScriptsDefaultParser :: Parser [TxId]
+hydraScriptsDefaultParser =
+  option
+    (eitherReader validateNetwork)
+    ( long "network"
+        <> metavar "NETWORK"
+        <> help "Uses the last pre-published hydra scripts for the given network."
+    )
+ where
+  validateNetwork arg =
+    case arg of
+      "preview" -> parseNetworkTxIds arg
+      "preprod" -> parseNetworkTxIds arg
+      "mainnet" -> parseNetworkTxIds arg
+      _ -> Left $ "Unknown network: " <> arg
+
 persistenceDirParser :: Parser FilePath
 persistenceDirParser =
   option