Update validateAddress function to only allow stake address of hex length 58

Author: reeshavacharya

src/controllers/address.ts

@@ -8,16 +8,11 @@ const router = Router()
 const getFaucetBalance = async (req: Request, res: Response): Promise<any> => {
     let address = convertToHexIfBech32(req.query.address as string)
     if (validateAddress(address)) {
-        if (address.length == 56) {
-            return res.status(400).json({ message: 'Provide a valid address' })
-        }
+        const balance = await fetchFaucetBalance(address)
+        return res.status(200).json(balance)
     } else {
         return res.status(400).json({ message: 'Provide a valid address' })
     }
-
-    const balance = await fetchFaucetBalance(address)
-
-    return res.status(200).json(balance)
 }
 
 router.get('/balance', handlerWrapper(getFaucetBalance))

src/controllers/delegation.ts

@@ -1,21 +1,20 @@
-import { Request, Response, Router } from "express";
-import { handlerWrapper } from "../errors/AppError";
-import { convertToHexIfBech32, validateAddress } from "../helpers/validator";
-import { fetchDelegationDetail } from "../repository/delegation";
+import { Request, Response, Router } from 'express'
+import { handlerWrapper } from '../errors/AppError'
+import { convertToHexIfBech32, validateAddress } from '../helpers/validator'
+import { fetchDelegationDetail } from '../repository/delegation'
 
-const router = Router();
+const router = Router()
 
 const getDelegation = async (req: Request, res: Response): Promise<any> => {
-  let address = convertToHexIfBech32(req.query.address as string);
-  if (validateAddress(address)){
-    address = address.length === 56 ? `e0${address}`:address
-  }else{
-    return res.status(400).json({message:'Provide a valid address'})
-  }
-  const result = await fetchDelegationDetail(address)
-  return res.status(200).json(result);
-};
+    let address = convertToHexIfBech32(req.query.address as string)
+    if (validateAddress(address)) {
+        const result = await fetchDelegationDetail(address)
+        return res.status(200).json(result)
+    } else {
+        return res.status(400).json({ message: 'Provide a valid address' })
+    }
+}
 
-router.get('/', handlerWrapper(getDelegation));
+router.get('/', handlerWrapper(getDelegation))
 
-export default router;
+export default router

src/controllers/stakeAddress.ts

@@ -8,15 +8,11 @@ const router = Router()
 const getStakeAddressDetails = async (req: Request, res: Response): Promise<any> => {
     let address = convertToHexIfBech32(req.query.address as string)
     if (validateAddress(address)) {
-        if (address.length == 56) {
-            return res.status(400).json({ mesage: `Provide a valid address` })
-        }
+        const result = await fetchStakeAddressDetails(address)
+        return res.status(200).json(result)
     } else {
         return res.status(400).json({ message: 'Provide a valid address' })
     }
-
-    const result = await fetchStakeAddressDetails(address)
-    return res.status(200).json(result)
 }
 
 router.get('/', handlerWrapper(getStakeAddressDetails))

src/helpers/validator.ts

@@ -105,7 +105,7 @@ export function fromHex(prefix: string, hex: string) {
 
 export function validateAddress(value: string): boolean {
     if (isHexValue(value)) {
-        return value.length === 56 || value.length === 58
+        return value.length === 58
     }
     return false
 }