Skip to content

Commit 7c05edf

Browse files
committed
refactor(tfidf): simplify ngram validation with all?(Integer)
1 parent 71d086c commit 7c05edf

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

lib/classifier/tfidf.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -237,9 +237,7 @@ def validate_df!(value, name)
237237
# @rbs (Array[Integer]) -> void
238238
def validate_ngram_range!(range)
239239
raise ArgumentError, 'ngram_range must be an array of two integers' unless range.is_a?(Array) && range.size == 2
240-
raise ArgumentError, 'ngram_range values must be positive integers' unless range.all? do |v|
241-
v.is_a?(Integer) && v.positive?
242-
end
240+
raise ArgumentError, 'ngram_range values must be positive integers' unless range.all?(Integer) && range.all?(&:positive?)
243241
raise ArgumentError, 'ngram_range[0] must be <= ngram_range[1]' if range[0] > range[1]
244242
end
245243

0 commit comments

Comments
 (0)