maint: build fix for ucptest and related code tyding up

Since 9a868b0 (Tidy up config.h management (task from README) (PCRE2Project#658),
2025-01-11), it fails to build with an "#error" because "config.h" is
no longer included directly.

Move the check and change some types in the utf8 tables it uses through
pcre2_ord2utf() so it better matches its current use, and other changes
in pcre2test.

While at it fix a typo in ManyConfigTests that was introduced in 0d0ac3a
(Update EBCDIC support to support testing on normal ASCII systems (PCRE2Project#656),
2025-02-12)

Author: carenas

maint/ManyConfigTests

@@ -40,7 +40,7 @@ usemainvalgrind=1
 usetmp=1
 usetmpjit=1
 useebcdic=1
-usebcdicjit=1
+useebcdicjit=1
 usevalgrind=1
 
 dummy=0

maint/ucptest.c

@@ -82,17 +82,17 @@ characters, the list ends with ...
 The command "list" must be followed by one of property names script, bool,
 type, gbreak or bidi. The defined values for that property are listed. */
 
-#ifndef SUPPORT_UNICODE
-#error "Unicode support not enabled"
-#endif
-
 #include <ctype.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include "../src/pcre2_internal.h"
 #include "../src/pcre2_ucp.h"
 
+#ifndef SUPPORT_UNICODE
+#error "Unicode support not enabled"
+#endif
+
 #ifdef HAVE_UNISTD_H
 #include <unistd.h>
 #endif

src/pcre2_internal.h

@@ -2233,7 +2233,7 @@ tables are needed only when compiling the 8-bit library. */
 
 #if PCRE2_CODE_UNIT_WIDTH == 8
 extern const int              PRIV(utf8_table1)[];
-extern const int              PRIV(utf8_table1_size);
+extern const unsigned         PRIV(utf8_table1_size);
 extern const int              PRIV(utf8_table2)[];
 extern const int              PRIV(utf8_table3)[];
 extern const uint8_t          PRIV(utf8_table4)[];

src/pcre2_ord2utf.c

@@ -80,16 +80,17 @@ PRIV(ord2utf)(uint32_t cvalue, PCRE2_UCHAR *buffer)
 /* Convert to UTF-8 */
 
 #if PCRE2_CODE_UNIT_WIDTH == 8
-int i, j;
+unsigned int i;
+
 for (i = 0; i < PRIV(utf8_table1_size); i++)
   if ((int)cvalue <= PRIV(utf8_table1)[i]) break;
 buffer += i;
-for (j = i; j > 0; j--)
+for (unsigned int j = i; j != 0; j--)
  {
  *buffer-- = 0x80 | (cvalue & 0x3f);
  cvalue >>= 6;
  }
-*buffer = PRIV(utf8_table2)[i] | cvalue;
+*buffer = (PCRE2_UCHAR)(PRIV(utf8_table2)[i] | (int)cvalue);
 return i + 1;
 
 /* Convert to UTF-16 */

src/pcre2_tables.c

@@ -51,6 +51,8 @@ defined. */
 #endif
 
 
+/* Utility macros */
+#define ARR_SIZE(x) sizeof(x)/sizeof(x[0])
 
 /* Table of sizes for the fixed-length opcodes. It's defined in a macro so that
 the definition is next to the definition of the opcodes in pcre2_internal.h.
@@ -100,15 +102,15 @@ handling wide characters. */
 character. */
 
 const int PRIV(utf8_table1)[] =
-  { 0x7f, 0x7ff, 0xffff, 0x1fffff, 0x3ffffff, 0x7fffffff};
+  { 0x7f, 0x7ff, 0xffff, 0x1fffff, 0x3ffffff, 0x7fffffff };
 
-const int PRIV(utf8_table1_size) = sizeof(PRIV(utf8_table1)) / sizeof(int);
+const unsigned PRIV(utf8_table1_size) = ARR_SIZE(PRIV(utf8_table1));
 
 /* These are the indicator bits and the mask for the data bits to set in the
 first byte of a character, indexed by the number of additional bytes. */
 
-const int PRIV(utf8_table2)[] = { 0,    0xc0, 0xe0, 0xf0, 0xf8, 0xfc};
-const int PRIV(utf8_table3)[] = { 0xff, 0x1f, 0x0f, 0x07, 0x03, 0x01};
+const int PRIV(utf8_table2)[] = { 0,    0xc0, 0xe0, 0xf0, 0xf8, 0xfc };
+const int PRIV(utf8_table3)[] = { 0xff, 0x1f, 0x0f, 0x07, 0x03, 0x01 };
 
 /* Table of the number of extra bytes, indexed by the first byte masked with
 0x3f. The highest number for a valid UTF-8 first byte is in fact 0x3d. */

src/pcre2test.c

@@ -3264,7 +3264,7 @@ for (j = 0; j < i; j++)
 
 /* Check that encoding was the correct unique one */
 
-for (j = 0; j < utf8_table1_size; j++)
+for (j = 0; j < (int)utf8_table1_size; j++)
   if (d <= (uint32_t)utf8_table1[j]) break;
 if (j != i) return -(i+1);
 
@@ -3340,7 +3340,7 @@ ord_to_utf8(uint32_t cvalue, uint8_t *utf8bytes)
 int i, j;
 if (cvalue > 0x7fffffffu)
   return -1;
-for (i = 0; i < utf8_table1_size; i++)
+for (i = 0; i < (int)utf8_table1_size; i++)
   if (cvalue <= (uint32_t)utf8_table1[i]) break;
 utf8bytes += i;
 for (j = i; j > 0; j--)
@@ -4026,11 +4026,13 @@ Returns:    < 0, = 0, or > 0, according to the comparison
 static int
 strncmpic(const uint8_t *s, const uint8_t *t, size_t n)
 {
-while (n--)
+if (n > 0) do
   {
   int c = tolower(*s++) - tolower(*t++);
   if (c != 0) return c;
   }
+while (--n > 0);
+
 return 0;
 }