fixed bug in convert_text_type

Author: daimor

dbt/adapters/iris/__version__.py

@@ -1 +1 @@
-version = "1.9.3"
+version = "1.9.8"

dbt/adapters/iris/impl.py

@@ -37,8 +37,8 @@ def date_function(cls):
     @classmethod
     def convert_text_type(cls, agate_table, col_idx):
         column = agate_table.columns[col_idx]
-        lens = (len(d.encode("utf-8")) for d in column.values_without_nulls())
-        max_len = max(lens) if lens else 64
+        lengths = [len(d.encode("utf-8")) for d in column.values_without_nulls()]
+        max_len = max(lengths) if lengths else 64
         length = max_len if max_len > 16 else 16
         return "varchar({})".format(length)
 

requirements-iris.txt

@@ -1 +1 @@
-https://github.com/intersystems-community/intersystems-irispython/releases/download/3.8.0/intersystems_iris-3.8.0-py3-none-any.whl
+https://github.com/intersystems-community/intersystems-irispython/releases/download/3.9.2/intersystems_iris-3.9.2-py3-none-any.whl

tests/functional/basic/test_adapter_methods.py

@@ -112,6 +112,39 @@ def test_adapter_methods(self, project, equal_tables):
         assert len(result) == 3
         check_relations_equal(project.adapter, equal_tables)
 
+    def test_convert_text_type(self, project):
+        class DummyColumn:
+            def __init__(self, values=[]):
+                self.values = values
+
+            def values_without_nulls(self):
+                return self.values
+
+        class DummyTable:
+            def __init__(self, columns):
+                self.columns = columns
+
+        table = DummyTable(
+            columns=[
+                DummyColumn(),
+                DummyColumn(
+                    [
+                        "short",
+                    ]
+                ),
+                DummyColumn(
+                    [
+                        "a bit longer text",
+                    ]
+                ),
+            ]
+        )
+        # default length is 64
+        assert project.adapter.convert_text_type(table, 0) == "varchar(64)"
+        # minimum length is 16
+        assert project.adapter.convert_text_type(table, 1) == "varchar(16)"
+        assert project.adapter.convert_text_type(table, 2) == "varchar(17)"
+
 
 class TestBaseCaching(BaseAdapterMethod):
     pass