Changes for Alert Statements, NO DEFAULT

Author: nmitchko

django_iris/base.py

@@ -182,3 +182,13 @@ def is_usable(self):
             return False
         else:
             return True
+
+    def schema_editor(self, *args, **kwargs):
+        """
+        Return a new instance of this backend's SchemaEditor.
+        """
+        if self.SchemaEditorClass is None:
+            raise NotImplementedError(
+                "The SchemaEditorClass attribute of this database wrapper is still None"
+            )
+        return DatabaseSchemaEditor(self, *args, **kwargs)

django_iris/compiler.py

@@ -0,0 +1,27 @@
+from django.core.exceptions import FieldError
+from django.db.models.expressions import Col
+from django.db.models.sql import compiler
+
+class SQLCompiler(compiler.SQLCompiler):
+    def as_subquery_condition(self, alias: str, columns, compiler):
+        return super().as_subquery_condition(alias, columns, compiler)
+
+
+class SQLInsertCompiler(compiler.SQLInsertCompiler, SQLCompiler):
+    def as_sql(self):
+        return super().as_sql()
+
+
+class SQLDeleteCompiler(compiler.SQLDeleteCompiler, SQLCompiler):
+    def as_sql(self):
+        return super().as_sql()
+
+
+class SQLUpdateCompiler(compiler.SQLUpdateCompiler, SQLCompiler):
+    def as_sql(self):
+        return super().as_sql()
+
+
+class SQLAggregateCompiler(compiler.SQLAggregateCompiler, SQLCompiler):
+    def as_sql(self):
+        return super().as_sql()

django_iris/operations.py

@@ -8,6 +8,9 @@
 import traceback
 
 class DatabaseOperations(BaseDatabaseOperations):
+
+    # compiler_module = "django_iris.compiler"
+
     def quote_name(self, name):
         if name.startswith('"') and name.endswith('"'):
             return name  # Quoting once is enough.

django_iris/schema.py

@@ -3,10 +3,19 @@
 from django.db.backends.base.schema import BaseDatabaseSchemaEditor
 from django.db import NotSupportedError
 
+
 class DatabaseSchemaEditor(BaseDatabaseSchemaEditor):
     sql_alter_column_type = "ALTER COLUMN %(column)s %(type)s"
     sql_alter_column_null = "ALTER COLUMN %(column)s NULL"
 
+    # Fix for correct alter column syntax
+    # ALTER TABLE tablename ALTER COLUMN oldname RENAME newname
+    sql_rename_column = (
+        "ALTER TABLE %(table)s ALTER COLUMN %(old_column)s RENAME %(new_column)s"
+    )
+
+    sql_rename_table = "ALTER TABLE %(old_table)s RENAME %(new_table)s"
+
     def quote_value(self, value):
         if isinstance(value, bool):
             return str(int(value))
@@ -26,4 +35,25 @@ def table_sql(self, model):
             raise NotSupportedError(
                 "Invalid table name '%s'" % (model._meta.db_table)
             )
-        return super().table_sql(model)
+        return super().table_sql(model)
+
+    def skip_default_on_alter(self, field):
+        """
+        Some backends don't accept default values for certain columns types
+        (i.e. MySQL longtext and longblob) in the ALTER COLUMN statement.
+        """
+        return True
+
+    # Due to DP-412796 and DP-412798 disable default fields
+    # on alter statements
+    def skip_default(self, field):
+        # return super().skip_default(field)
+        return True
+
+    # def _rename_field_sql(self, table, old_field, new_field, new_type):
+    #     return self.sql_rename_column % {
+    #         "table": self.quote_name(table),
+    #         "old_column": self.quote_name(old_field.column),
+    #         "new_column": self.quote_name(new_field.column),
+    #         "type": new_type,
+    #     }

setup.cfg

@@ -1,6 +1,6 @@
 [metadata]
 name = django-iris
-version = 0.1.7
+version = 0.1.8b4
 url = https://github.com/caretdev/django-iris
 maintainer = CaretDev
 maintainer_email = [email protected]