subprocess fails to launch irisdb with Shell=True

[george-james-software]

After installing iterm on a Linux server running 2024.1 the /iterm url returns a black screen with a blinking cursor but no response from the server. It would appear that subprocess.Popen in iTerm.Engine.cls is being called incorrectly. The shell argument should not be set to True.

This issue can be resolved by removing line 176 as below.

Method start() [ Language = python ]
{
import iris
import pty
import subprocess

bin = iris.system.Util.BinaryDirectory() + "irisdb"
mgr = iris.system.Util.ManagerDirectory()
username = iris.system.Process.UserName()
namespace = iris.system.Process.NameSpace()
cmd = [bin, "-s", mgr]
#; cmd = ["sh", "-c", " ".join(cmd)]
#; cmd = ["bash"]

master_fd, slave_fd = pty.openpty()

proc = subprocess.Popen(
cmd,
stdin=slave_fd,
stdout=slave_fd,
stderr=slave_fd,
close_fds=True,
#; shell=True,
start_new_session=True,
)

return master_fd, proc
}