Method-scoped Attributes and Attribute parameters are not detected

[darthf1]

Hi!

I have a class in the Domain namespace, which has Doctrine's attributes for ORM mapping. My classes have the following imports:

<?php

declare(strict_types=1);

namespace Domain\MyDomain;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use Doctrine\DBAL\Types\Types;
use Doctrine\ORM\Mapping as ORM;

With the test below:

public function testDomainLayerOnlyDependsOnDomainLayer(): Rule
{
    return PHPat::rule()
        ->classes(
            Selector::namespace('/^Domain.*/', true),
        )
        ->shouldNotDependOn()
        ->classes(
            Selector::NOT(Selector::namespace('/^Domain.*/', true)),
        )
    ;
}

I get:

 ------ ------------------------------------------------------------------------------------------------- 
  Line   src/Domain/MyDomain\MyClass.php                                                           
 ------ ------------------------------------------------------------------------------------------------- 
  43     Domain\MyDomain\MyClass should not depend on Doctrine\DBAL\Types\Types                    
  48     Domain\MyDomain\MyClass should not depend on Doctrine\DBAL\Types\Types                    
  51     Domain\MyDomain\MyClass should not depend on Doctrine\DBAL\Types\Types                    
  54     Domain\MyDomain\MyClass should not depend on Doctrine\DBAL\Types\Types                    
  57     Domain\MyDomain\MyClass should not depend on Doctrine\DBAL\Types\Types                    
  60     Domain\MyDomain\MyClass should not depend on Doctrine\DBAL\Types\Types                    
  63     Domain\MyDomain\MyClass should not depend on Doctrine\DBAL\Types\Types                    
  69     Domain\MyDomain\MyClass should not depend on Doctrine\Common\Collections\Collection       
  75     Domain\MyDomain\MyClass should not depend on Doctrine\Common\Collections\Collection       
  95     Domain\MyDomain\MyClass should not depend on Doctrine\Common\Collections\ArrayCollection  
  102    Domain\MyDomain\MyClass should not depend on Doctrine\Common\Collections\ArrayCollection  
 ------ ------------------------------------------------------------------------------------------------- 

There is no mention of the import:

use Doctrine\ORM\Mapping as ORM;

Using a direct import also is not reported:

use Doctrine\ORM\Mapping\Column;

[carlosas]

I don't think imports should be reported. However, used attributes should, but the rule is still not created.
I will keep this issue open for that matter, as it's something I'm planning to do soon.

[carlosas]

Class-scoped Attributes should be catch now with https://github.com/carlosas/phpat/releases/tag/0.10.4
However, method-scoped Attributes and Attribute parameters are not implemented yet